Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix PidPressure, and add fork-bomb e2e-node test #72844
What type of PR is this?
What this PR does / why we need it:
As we don't have easily available process metrics, this PR uses only priority as the way to rank pods for eviction in response to PidPressure. While this isn't ideal, it is better than no eviction at all IMO. We can iterate on this if needed.
The e2e node test sets the eviction threshold such that with 10k additional processes the eviction threshold will be crossed, and the fork-bomb container creates 12k processes.
This PR also makes a minor change to the message when a pod fails admission due to pressure, changing the message from "The node was low on resource: [Diskpressure]" to "The node had condition: [DiskPressure]".
It also changes eviction tests to use constants from the eviction api, such as
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?:
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here