New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fallback to first type if having candidates #72845

Closed
wants to merge 1 commit into
base: master
from

Conversation

@oomichi
Copy link
Member

oomichi commented Jan 12, 2019

TODO

  • need unit test
  • verify this works fine for integration tests

What type of PR is this?
/kind bug
/kind failing-test
/kind flake

What this PR does / why we need it:

Before giving up to get the most appropriate content type,
this makes the method returns the first type if having some
candidates.

Which issue(s) this PR fixes:
Fixes #71696

Fallback to first type if having candidates
Before giving up to get the most appropriate content type,
this makes the method returns the first type if having some
candidates.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 12, 2019

@oomichi: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 12, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oomichi
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 12, 2019

@oomichi: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test 02e2dfd link /test pull-kubernetes-bazel-test
pull-kubernetes-e2e-kops-aws 02e2dfd link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-e2e-gce 02e2dfd link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oomichi

This comment has been minimized.

Copy link
Member

oomichi commented Jan 14, 2019

already fixed

@oomichi oomichi closed this Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment