Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix nil panic propagation #72856
What type of PR is this?
What this PR does / why we need it:
When the response actually did panic, this code worked properly.
When the response did not panic, it would send nil, racing the err and result channels. When the panic-propagating channel won the race, a nil panic would be thrown. This would short-circuit all response writing, resulting in no content type and no status code, but maddeningly, would not be logged (because the object sent to panic was
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: liggitt
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing