New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubeadm/HA: pull images during join for control-plane #72870

Merged
merged 1 commit into from Jan 16, 2019

Conversation

@MalloZup
Copy link
Contributor

MalloZup commented Jan 13, 2019

/kind feature

What this PR does / why we need it:

Kubeadm/HA: pull images during join for control-plane

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#1341

Does this PR introduce a user-facing change?:

kubeadm: pull images when joining a new control plane instance
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 13, 2019

Hi @MalloZup. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Jan 13, 2019

Fixes # kubernetes/kubeadm#1341

there should be no space after # for this to trigger a close on the issue. use this:
Fixes kubernetes/kubeadm#1341

Imho the image methods and related should be moved out of config.go
I can do the refactor in this pr.

i don't think we should do that or at least in the same PR.

enable kubeadm on join phase to pull controlplane control-plane images

please change the release note to:
kubeadm: pull images when joining a new control plane instance

/priority important-longterm
/kind bug

@neolit123
Copy link
Member

neolit123 left a comment

@MalloZup thank you for working on this.
added some initial feedback that you can address.

Show resolved Hide resolved cmd/kubeadm/app/cmd/config.go Outdated
Show resolved Hide resolved cmd/kubeadm/app/cmd/config_test.go Outdated
Show resolved Hide resolved cmd/kubeadm/app/cmd/join.go Outdated
Show resolved Hide resolved cmd/kubeadm/app/cmd/join.go Outdated
Show resolved Hide resolved cmd/kubeadm/app/cmd/join.go Outdated
Show resolved Hide resolved cmd/kubeadm/app/cmd/join.go Outdated
@MalloZup

This comment has been minimized.

Copy link
Contributor Author

MalloZup commented Jan 13, 2019

@neolit123 thx for nice review. I will adress your comment during the week 🚀 🎸 🌱

@MalloZup MalloZup force-pushed the MalloZup:fix-join-ha branch 2 times, most recently from c8b29f0 to 09c6be0 Jan 14, 2019

@MalloZup

This comment has been minimized.

Copy link
Contributor Author

MalloZup commented Jan 14, 2019

Refactoring issues that can be fixed later and need creation.

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Jan 14, 2019

/approve

@fabriziopandini
Copy link
Contributor

fabriziopandini left a comment

@MalloZup thanks for this PR!
/approve
Please address comments then IMO this it is ready for lgtm
@kad could you take a look at this PR?

@MalloZup MalloZup force-pushed the MalloZup:fix-join-ha branch 2 times, most recently from 7c6d930 to 2af28c2 Jan 15, 2019

@MalloZup

This comment has been minimized.

Copy link
Contributor Author

MalloZup commented Jan 15, 2019

Regarding minor changes : #72909

@rosti
Copy link
Member

rosti left a comment

I'd rather like to see this use RunPullImagesCheck. We need to reuse code more often.

@MalloZup

This comment has been minimized.

Copy link
Contributor Author

MalloZup commented Jan 15, 2019

I'd rather like to see this use RunPullImagesCheck. We need to reuse code more often.

@rosti i agree with your pov. To me also the function should called CheckAndRunPullImages to avoid ambigous. ( initially i was thinking it was only a check`)

Imho we should have instead of 2 similar function only one. For this Pr i can use the RunPullImagesCheck and later on refactor the codebase to use only that one if we agree 🚀


i have created a small list for follow-up issues refactoring: #72870 (comment)

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Jan 15, 2019

@MalloZup

To me also the function should called CheckAndRunPullImages to avoid ambigous. ( initially i was thinking it was only a check`)

the name might be a bit confusing but i think we can skip the rename for now.
please update the PR to use RunPullImagesCheck as @rosti suggested.
thanks.

@MalloZup

This comment has been minimized.

Copy link
Contributor Author

MalloZup commented Jan 15, 2019

@neolit123 yop i was going to do it. I will send another PR for renaming. i got your the workflow now 🌞

@rosti

This comment has been minimized.

Copy link
Member

rosti commented Jan 15, 2019

+1 for the renaming, but indeed, this needs to be done in another PR.

@MalloZup MalloZup force-pushed the MalloZup:fix-join-ha branch from 2af28c2 to eec8e9a Jan 15, 2019

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Jan 15, 2019

@MalloZup

This comment has been minimized.

Copy link
Contributor Author

MalloZup commented Jan 15, 2019

i have update to use the call suggested. I don't have much network at moment i will test it asap. I think should be ok.

@MalloZup

This comment has been minimized.

Copy link
Contributor Author

MalloZup commented Jan 15, 2019

/retest

Pre-pull images after preflight for HA setup.
If download fails continue with a warning only

@MalloZup MalloZup force-pushed the MalloZup:fix-join-ha branch from eec8e9a to 86b6bbd Jan 15, 2019

@MalloZup

This comment has been minimized.

Copy link
Contributor Author

MalloZup commented Jan 15, 2019

/retest

@MalloZup

This comment has been minimized.

Copy link
Contributor Author

MalloZup commented Jan 15, 2019

works fine now, 🚀 🌻

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 16, 2019

@rosti

rosti approved these changes Jan 16, 2019

Copy link
Member

rosti left a comment

Looks great now! Thanks @MalloZup !

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, MalloZup, neolit123, rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MalloZup

This comment has been minimized.

Copy link
Contributor Author

MalloZup commented Jan 16, 2019

thx @rosti @neolit123 , @fabriziopandini for reviews and @ereslibre 🌵

@k8s-ci-robot k8s-ci-robot merged commit 6d479af into kubernetes:master Jan 16, 2019

18 checks passed

cla/linuxfoundation MalloZup authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment