New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove swagger 1.2, swagger-ui #72924

Merged
merged 3 commits into from Jan 16, 2019

Conversation

@liggitt
Copy link
Member

liggitt commented Jan 15, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #72921
Fixes #38637

Does this PR introduce a user-facing change?:

The `/swaggerapi/*` schema docs, deprecated since 1.7, have been removed in favor of the /openapi/v2 schema docs.

/sig api-machinery
/cc @sttts @mbohlool

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt force-pushed the liggitt:remove-swagger branch from 5f4f468 to 3596df5 Jan 15, 2019

@liggitt liggitt force-pushed the liggitt:remove-swagger branch 2 times, most recently from c67d4d2 to f76d6ac Jan 15, 2019

@liggitt liggitt force-pushed the liggitt:remove-swagger branch 2 times, most recently from 45cb995 to aff14d0 Jan 15, 2019

liggitt added some commits Jan 15, 2019

@liggitt liggitt force-pushed the liggitt:remove-swagger branch from aff14d0 to ef4983f Jan 15, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 15, 2019

/retest

@liggitt liggitt changed the title WIP - Remove swagger 1.2, swagger-ui Remove swagger 1.2, swagger-ui Jan 15, 2019

@deads2k

This comment has been minimized.

Copy link
Contributor

deads2k commented Jan 15, 2019

happy day!

lgtm

@mbohlool

This comment has been minimized.

Copy link
Member

mbohlool commented Jan 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 15, 2019

@k8s-ci-robot k8s-ci-robot merged commit 7a8ac58 into kubernetes:master Jan 16, 2019

18 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Job succeeded.
Details
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Show resolved Hide resolved go.mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment