Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cmd what #72939

Merged
merged 19 commits into from Feb 23, 2019

Conversation

@runyontr
Copy link
Contributor

commented Jan 15, 2019

What type of PR is this?
Add ability to test single functions in test/cmd/

What this PR does / why we need it:

This PR provides the WHAT argument for running CLI tests. It also moves the kubeadm tests into the test/cmd folder.

For example:

make test-cmd WHAT="deployment impersonation"

calls the run_deployment_test and run_impersonation_test functions.

make test-cmd WHAT=kubeadm

runs the previosly named hack/make-rules/test-kubeadm-cmd.sh

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

runyontr added some commits Jan 15, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2019

Hi @runyontr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runyontr

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

I signed it

@cblecker

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

/ok-to-test

@runyontr

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

/retest

@runyontr

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

/test pull-kubernetes-verify

@runyontr

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

/test pull-kubernetes-verify

@runyontr

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2019

/test pull-kubernetes-integration
/test pull-kubernetes-verify

@runyontr

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2019

/test pull-kubernetes-verify

@k8s-ci-robot k8s-ci-robot added size/M and removed size/XL labels Feb 21, 2019

@spiffxp

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

/kind cleanup
/priority important-soon
/retest

@spiffxp

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

/sig cli
/sig api-machineruy
/sig cluster-lifecycle
because they all have some ownership of things in cmd

@runyontr

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2019

/retest

@spiffxp

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

I'm trying to use this locally to isolate the flake you seem to be running into, and it seems like the local processes don't get torn down at the end?

$ make test-cmd WHAT=kubectl_run
# ...
+++ [0222 17:42:07] TESTS PASSED
warning: Immediate deletion does not wait for confirmation that the running resource has been terminated. The resource may continue to run on the cluster indefinitely.
No resources found
warning: Immediate deletion does not wait for confirmation that the running resource has been terminated. The resource may continue to run on the cluster indefinitely.
No resources found
$ make test-cmd WHAT=kubectl_run
+++ [0222 17:42:28] Running kubectl tests for kube-apiserver

unable to start etcd as port 2379 is in use. please stop the process listening on this port and retry.


tcp4       0      0  127.0.0.1.2379         *.*                    LISTEN

junit report dir: /tmp/junit-results
+++ [0222 17:42:28] Clean up complete
make: *** [test-cmd] Error 1
@spiffxp

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

/retest
pull-kubernetes-e2e-gce failures look like unrelated flakes

@spiffxp

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

/approve
I think I might have some whitespace nits but those can be done in a followup, I found this useful as-is

@spiffxp

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

/lgtm
Yeah, I didn't think I had build/ approve rights
/assign @ixdy @cblecker

@cblecker

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

/approve
77749a8f-dddb-409b-b63c-2f6f551963e2

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, runyontr, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0133d14 into kubernetes:master Feb 23, 2019

16 checks passed

cla/linuxfoundation runyontr authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped
tide In merge pool.
Details
@neolit123

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

make test-cmd WHAT=kubeadm

the above suggested line builds kubectl and the whole control plane to be able to test this package cmd/kubeadm/test. this is completely redundant.

this PR introduces a workflow change without a deprecation period.
right now my quick local fix is to introduce the old ./hack/make-rules/test-kubeadm-cmd.sh.
(edit: doesn't work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.