Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upremove remaining deprecated taints from 1.9 #73001
Conversation
k8s-ci-robot
added
release-note
size/L
cncf-cla: yes
needs-kind
labels
Jan 17, 2019
This comment has been minimized.
This comment has been minimized.
Hi @shivnagarajan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-sig
needs-priority
needs-ok-to-test
labels
Jan 17, 2019
k8s-ci-robot
requested review from
derekwaynecarr
and
k82cn
Jan 17, 2019
k8s-ci-robot
added
sig/apps
sig/scheduling
and removed
needs-sig
labels
Jan 17, 2019
This comment has been minimized.
This comment has been minimized.
k8s-ci-robot
requested review from
bsalamat
and
resouer
Jan 17, 2019
This comment has been minimized.
This comment has been minimized.
/ok-to-test |
k8s-ci-robot
added
ok-to-test
and removed
needs-ok-to-test
labels
Jan 17, 2019
This comment has been minimized.
This comment has been minimized.
/approve for nodelifecycle and scheduler part :) |
This comment has been minimized.
This comment has been minimized.
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
and removed
needs-kind
labels
Jan 17, 2019
This comment has been minimized.
This comment has been minimized.
/assign @deads2k |
k8s-ci-robot
assigned
deads2k
Jan 17, 2019
This comment has been minimized.
This comment has been minimized.
/assign @derekwaynecarr |
k8s-ci-robot
assigned
derekwaynecarr
Jan 17, 2019
This comment has been minimized.
This comment has been minimized.
ping @deads2k @derekwaynecarr Could either of you take a quick look? You are listed as owners/approvers for
|
k8s-ci-robot
assigned
yastij
Jan 18, 2019
k8s-ci-robot
added
the
lgtm
label
Jan 18, 2019
This comment has been minimized.
This comment has been minimized.
/priority backlog |
k8s-ci-robot
added
priority/backlog
and removed
needs-priority
labels
Jan 18, 2019
This comment has been minimized.
This comment has been minimized.
Is there someone else available to review/approve this? |
resouer
approved these changes
Jan 22, 2019
k8s-ci-robot
assigned
liggitt and
resouer
Jan 22, 2019
This comment has been minimized.
This comment has been minimized.
@resouer: GitHub didn't allow me to assign the following users: for, approve. Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This comment has been minimized.
This comment has been minimized.
/approve |
This comment has been minimized.
This comment has been minimized.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, liggitt, shivnagarajan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
label
Jan 24, 2019
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Jan 24, 2019
/retest Review the full test history for this PR. Silence the bot with an |
shivnagarajan commentedJan 17, 2019
What this PR does / why we need it:
This relates to #64260
which was the previous attempt at removing the deprecated tolerations.
Since these deprecated tolerations need no longer be supported, it is better to completely remove support for them. This change completely removes all references to DeprecatedTaintNodeUnreachable and DeprecatedTaintNodeNotReady.
To remove confusion, and based on previous comments in the code, this change removes all of the handling for the deprecated tolerations altogether. This follows the deprecation policy outlined in https://kubernetes.io/docs/reference/using-api/deprecation-policy/.
Special notes for your reviewer:
Release note: