New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove remaining deprecated taints from 1.9 #73001

Merged
merged 1 commit into from Jan 24, 2019

Conversation

@shivnagarajan
Copy link
Contributor

shivnagarajan commented Jan 17, 2019

What this PR does / why we need it:

馃憢 Am new here 馃槃

This relates to #64260

which was the previous attempt at removing the deprecated tolerations.

Since these deprecated tolerations need no longer be supported, it is better to completely remove support for them. This change completely removes all references to DeprecatedTaintNodeUnreachable and DeprecatedTaintNodeNotReady.

To remove confusion, and based on previous comments in the code, this change removes all of the handling for the deprecated tolerations altogether. This follows the deprecation policy outlined in https://kubernetes.io/docs/reference/using-api/deprecation-policy/.

Special notes for your reviewer:

Release note:

As per deprecation policy in https://kubernetes.io/docs/reference/using-api/deprecation-policy/ 
the taints "node.alpha.kubernetes.io/notReady" and "node.alpha.kubernetes.io/unreachable".  are no
longer supported or adjusted. These uses should be replaced with "node.kubernetes.io/not-ready" 
and "node.kubernetes.io/unreachable" respectively instead.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 17, 2019

Hi @shivnagarajan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shivnagarajan

This comment has been minimized.

Copy link
Contributor Author

shivnagarajan commented Jan 17, 2019

@k8s-ci-robot k8s-ci-robot requested review from bsalamat and resouer Jan 17, 2019

@xiaoxubeii

This comment has been minimized.

Copy link
Member

xiaoxubeii commented Jan 17, 2019

/ok-to-test

@k82cn

This comment has been minimized.

Copy link
Member

k82cn commented Jan 17, 2019

/approve for nodelifecycle and scheduler part :)

@k82cn

This comment has been minimized.

Copy link
Member

k82cn commented Jan 17, 2019

/kind cleanup

@shivnagarajan

This comment has been minimized.

Copy link
Contributor Author

shivnagarajan commented Jan 17, 2019

/assign @deads2k

@shivnagarajan

This comment has been minimized.

Copy link
Contributor Author

shivnagarajan commented Jan 17, 2019

/assign @derekwaynecarr

@shivnagarajan

This comment has been minimized.

Copy link
Contributor Author

shivnagarajan commented Jan 18, 2019

ping @deads2k @derekwaynecarr

Could either of you take a quick look? You are listed as owners/approvers for

  • plugin/pkg/admission/OWNERS
@yastij

yastij approved these changes Jan 18, 2019

Copy link
Member

yastij left a comment

/lgtm

@yastij

This comment has been minimized.

Copy link
Member

yastij commented Jan 18, 2019

/priority backlog

@shivnagarajan

This comment has been minimized.

Copy link
Contributor Author

shivnagarajan commented Jan 22, 2019

Is there someone else available to review/approve this?

@resouer
Copy link
Member

resouer left a comment

/lgtm

/assign @liggitt
for approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 22, 2019

@resouer: GitHub didn't allow me to assign the following users: for, approve.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/lgtm

/assign @liggitt for approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 24, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, liggitt, shivnagarajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 24, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 4cd759d into kubernetes:master Jan 24, 2019

18 checks passed

cla/linuxfoundation shivnagarajan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@shivnagarajan shivnagarajan deleted the shivnagarajan:remove_deprecated_taints branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment