New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsonpath slice step handling #73149

Merged
merged 1 commit into from Jan 22, 2019

Conversation

@liggitt
Copy link
Member

liggitt commented Jan 21, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes step handling of jsonpath expressions.

Does this PR introduce a user-facing change?:

jsonpath expressions containing `[start:end:step]` slice are now evaluated correctly

/sig api-machinery
/cc @smarterclayton

@liggitt liggitt force-pushed the liggitt:jsonpath-range-step branch from aaa08bc to 233d7e4 Jan 21, 2019

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Jan 22, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 27e5971 into kubernetes:master Jan 22, 2019

18 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
step := 1
if params[2].Known {
if params[2].Value <= 0 {
return input, fmt.Errorf("step must be >= 0")

This comment has been minimized.

@tedyu

tedyu Jan 22, 2019

Contributor

A bit curious: why is step of zero allowed ?

This comment has been minimized.

@liggitt

liggitt Jan 22, 2019

Author Member

it is not allowed. a step size of 0 means that no progress would be made between the start and end

This comment has been minimized.

@liggitt

liggitt Jan 22, 2019

Author Member

oh, I see... the message is incorrect

This comment has been minimized.

@tedyu

tedyu Jan 22, 2019

Contributor

Should I send out PR to correct the message ?

This comment has been minimized.

@liggitt

liggitt Jan 22, 2019

Author Member

sure, thanks

This comment has been minimized.

@tedyu

tedyu Jan 22, 2019

Contributor

Created #73179

@liggitt liggitt deleted the liggitt:jsonpath-range-step branch Jan 22, 2019

@fedebongio

This comment has been minimized.

Copy link
Contributor

fedebongio commented Jan 24, 2019

/cc @mbohlool

@k8s-ci-robot k8s-ci-robot requested a review from mbohlool Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment