New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused const #73350

Open
wants to merge 1 commit into
base: master
from

Conversation

@hello2mao
Copy link
Member

hello2mao commented Jan 26, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Remove unused const since this PR #70344

None
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 26, 2019

Hi @hello2mao. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from andrewsykim and thockin Jan 26, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 26, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hello2mao
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: luxas

If they are not already assigned, you can assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hello2mao

This comment has been minimized.

Copy link
Member Author

hello2mao commented Jan 30, 2019

/assign @andrewsykim

@andrewsykim

This comment has been minimized.

Copy link
Member

andrewsykim commented Jan 30, 2019

/ok-to-test

@hello2mao

This comment has been minimized.

Copy link
Member Author

hello2mao commented Jan 30, 2019

/test pull-kubernetes-integration

@hello2mao

This comment has been minimized.

Copy link
Member Author

hello2mao commented Feb 12, 2019

/test pull-kubernetes-e2e-kops-aws

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 12, 2019

@hello2mao: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws cbfe654 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hello2mao

This comment has been minimized.

Copy link
Member Author

hello2mao commented Feb 12, 2019

hi @andrewsykim ,the check pull-kubernetes-e2e-kops-aws failed because of this #73444 and it is not REQUIRED.
I would appreciate it if you could review this cleanup PR.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment