New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go1.10.8 #73379

Merged
merged 2 commits into from Jan 31, 2019

Conversation

@cblecker
Copy link
Member

cblecker commented Jan 27, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it: updates to use go1.10.8, which fixes CVE-2019-6486.

Which issue(s) this PR fixes:
x-ref #73238

Does this PR introduce a user-facing change?:

Update to go1.10.8

/assign @BenTheElder @ixdy @foxish
/sig release
/priority critical-urgent

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 27, 2019

@cblecker: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker cblecker changed the base branch from master to release-1.11 Jan 27, 2019

@k8s-ci-robot k8s-ci-robot added the size/S label Jan 27, 2019

@k8s-ci-robot k8s-ci-robot requested review from lavalamp and mkumatag Jan 27, 2019

@cblecker cblecker removed the needs-rebase label Jan 27, 2019

@cblecker cblecker force-pushed the cblecker:k8s1.11-go1.10.8 branch from 91469fb to 99a5828 Jan 27, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker cblecker referenced this pull request Jan 27, 2019

Closed

Tracking issue: Update to go1.11.5 and 1.10.8 #73238

5 of 5 tasks complete

@kubernetes kubernetes deleted a comment from k8s-ci-robot Jan 27, 2019

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Jan 27, 2019

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Jan 27, 2019

/retest

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Jan 28, 2019

those failures make no sense...

/retest

@@ -1,5 +1,8 @@
startup --expand_configs_in_place

# don't error on error on deprecated native http_archive rule
build --incompatible_remove_native_http_archive=false

This comment has been minimized.

@ixdy

ixdy Jan 28, 2019

Member

I think this might be getting removed in bazel 0.23.0, but we're pinned to an old version of bazel on CI anyway.

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Jan 28, 2019

wait, what?

W0128 19:35:15.704] bootstrap.py is deprecated!
Please migrate your job to podutils!
https://github.com/kubernetes/test-infra/blob/master/prow/pod-utilities.md
I0128 19:35:15.704] Args: --job=pull-kubernetes-e2e-kops-aws --service-account=/etc/service-account/service-account.json --upload=gs://kubernetes-jenkins/logs --root=/go/src --job=pull-kubernetes-e2e-kops-aws --repo=k8s.io/kubernetes=release-1.11:3a10094374f22b621b3379a2f6cb81025ffe543f,73379:1b749e7a53d79304df59fa2ddfac59e10e7b5292 --repo=k8s.io/release --service-account=/etc/service-account/service-account.json --upload=gs://kubernetes-jenkins/pr-logs --timeout=75 --scenario=kubernetes_e2e -- --aws --aws-cluster-domain=test-cncf-aws.k8s.io --build=bazel --cluster= --env=KOPS_LATEST=latest-ci-green.txt --env=KOPS_DEPLOY_LATEST_KUBE=n --env=KUBE_GCS_UPDATE_LATEST=n --env=KUBE_FASTBUILD=true --extract=local --ginkgo-parallel --provider=aws --stage=gs://kubernetes-release-pull/ci/pull-kubernetes-e2e-kops-aws '--test_args=--ginkgo.flakeAttempts=2 --ginkgo.skip=\[Slow\]|\[Serial\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\]|\[HPA\]|Dashboard|Services.*functioning.*NodePort' --timeout=55m
I0128 19:35:15.704] Bootstrap pull-kubernetes-e2e-kops-aws...
I0128 19:35:15.708] Builder: gke-prow-containerd-pool-99179761-btf8
I0128 19:35:15.709] Image: gcr.io/k8s-testimages/kubekins-e2e:v20190125-3d9554697e-master
I0128 19:35:15.709] Gubernator results at https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/73379/pull-kubernetes-e2e-kops-aws/120860
...

That's not right: gcr.io/k8s-testimages/kubekins-e2e:v20190125-3d9554697e-master

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Jan 28, 2019

Somehow we never created branched versions of pull-kubernetes-e2e-kops-aws, pull-kubernetes-e2e-gce-device-plugin-gpu, pull-kubernetes-kubemark-e2e-gce-big, and pull-kubernetes-e2e-gce for release-1.11 and release-1.12.

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Jan 28, 2019

cc @amwat

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Jan 29, 2019

/retest

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Jan 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 29, 2019

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Jan 30, 2019

/retest

1 similar comment
@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Jan 30, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 30, 2019

@cblecker: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 1b749e7 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Jan 30, 2019

/skip

@foxish foxish added this to the v1.11 milestone Jan 31, 2019

@k8s-ci-robot k8s-ci-robot merged commit fea9872 into kubernetes:release-1.11 Jan 31, 2019

18 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Skipped
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment