Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Kubelet: Fix volumemanager test race #73404
What type of PR is this?
What this PR does / why we need it:
There is a race in the kubelet volume manager's reconciler test: the volume plugin hooks are being set while the reconciliation loop is running. It should be stopped for a while when setting up the hooks in the middle of the test.
referenced this pull request
Jan 30, 2019
1 similar comment
@saad-ali yes, that was my first idea too. I've tried it and realized from the logs that it changed the test flow: The attach hook would be called twice and the
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
2 similar comments
17 similar comments
5 similar comments
@tsmetana: The following test failed, say