New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated AWS SDK to v1.16.26 for ECR PrivateLink support #73435

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@micahhausler
Copy link
Member

micahhausler commented Jan 28, 2019

What type of PR is this?

/kind feature
/sig aws

What this PR does / why we need it:

AWS recently launched private link support for ECR, but in doing so changed the API endpoint for ECR. The latest AWS SDK (v1.16.26) includes updates to the new API endpoint. The existing endpoint will continue to work for existing clients, but won't work with PrivateLink.

Which issue(s) this PR fixes:

Fixes #73334

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Updated AWS SDK to v1.16.26 for ECR PrivateLink support
@micahhausler

This comment has been minimized.

Copy link
Member Author

micahhausler commented Jan 28, 2019

/test pull-kubernetes-node-e2e

@micahhausler

This comment has been minimized.

Copy link
Member Author

micahhausler commented Jan 29, 2019

/test pull-kubernetes-e2e-kops-aws

/test pull-kubernetes-node-e2e

@micahhausler

This comment has been minimized.

Copy link
Member Author

micahhausler commented Jan 29, 2019

/test pull-kubernetes-e2e-kops-aws

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 29, 2019

@micahhausler: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 9842136 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Feb 4, 2019

From a "self-contained" POV this is fine. Godeps are OK and changes are constrained.

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micahhausler, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 10a4d5a into kubernetes:master Feb 4, 2019

18 checks passed

cla/linuxfoundation micahhausler authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Context retired without replacement.
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@micahhausler micahhausler deleted the micahhausler:aws-sdk-update-201901 branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment