test/e2e/framework: validate external node IPs

[crawford]

What type of PR is this?
/kind bug

What this PR does / why we need it:
It is possible for a node not to have an external IP address. This extra
check is copied directly from GetNodeInternalIP and prevents errors like
the following:

INFO: Getting external IP address for ip-10-0-133-82.ec2.internal
error dialing core@:22: 'dial tcp :22: connect: connection refused'

In this case, there was no public IP for this host, but
GetNodeExternalIP returned ":22" instead of an error.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Hi @crawford. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[neolit123]

thanks @crawford

/lgtm
/ok-to-test
/priority backlog

[smarterclayton]

/retest

[crawford]

Based on https://gubernator.k8s.io/builds/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-e2e-kops-aws, it looks like e2e-kops-aws fails quite a bit. I don't think this change is related to the failures I'm seeing.

/retest

[crawford]

/retest

[k8s-ci-robot]

@crawford: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-kops-aws	7378ebc	link	/test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[smarterclayton]

Only concern here is if this causes some of the extended suites to start failing post submit.

@kubernetes/sig-testing-pr-reviews who is most likely to know what the odds are of a break (testing a cluster with no external ip but a reachable internal ip)?

[BenTheElder]

kops AWS is #73444
not sure how likely this is to break, at least it looks like it won't break what we're already doing.

[timothysc]

/approve
/hold

I'd be surprised if this causes other failures, feel free to unhold on all clear.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [timothysc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@crawford: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[crawford]

Superseded by #76637.

[k8s-ci-robot]

@crawford: Closed this PR.

In response to this:

Superseded by #76637.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.