Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix node e2e localstorage eviction tests #73486
Conversation
k8s-ci-robot
assigned
Random-Liu and
yguo0905
Jan 29, 2019
k8s-ci-robot
added
release-note-none
kind/failing-test
sig/node
priority/important-soon
cncf-cla: yes
sig/testing
labels
Jan 29, 2019
k8s-ci-robot
requested review from
tallclair
and
vishh
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
/lgtm |
k8s-ci-robot
added
the
lgtm
label
Jan 30, 2019
This comment has been minimized.
This comment has been minimized.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, Random-Liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
label
Jan 30, 2019
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Jan 31, 2019
/retest Review the full test history for this PR. Silence the bot with an |
14 similar comments
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Jan 31, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Jan 31, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Jan 31, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Jan 31, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Jan 31, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Jan 31, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Jan 31, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Jan 31, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Feb 1, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Feb 1, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Feb 1, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Feb 1, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Feb 1, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
fejta-bot
commented
Feb 1, 2019
/retest Review the full test history for this PR. Silence the bot with an |
This comment has been minimized.
This comment has been minimized.
@dashpole: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dashpole commentedJan 29, 2019
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This makes a few improvements to the local storage eviction tests:
This also increases the amount of disk space that needs to be used before hitting the local storage eviction thresholds from 100Mi to 200Mi.
Which issue(s) this PR fixes:
Issue #73031
Testgrid Link
Special notes for your reviewer:
The test was failing because something on the node consumed disk space between when the eviction threshold was set and when the pods were created, causing the test pods to be rejected. This is mitigated by the larger amount required to reclaim, and batch creation, which speeds up the creation process for pods. Occasionally, the tests would also fail because the kubelet would evict pods before it collected disk metrics for them. To mitigate this, I added rate limiting to the disk consumption.
Does this PR introduce a user-facing change?:
/sig node
/priority important-soon
/assign @Random-Liu @yguo0905