Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Ensure directories are executable for fsGroup #73533
What type of PR is this?
What this PR does / why we need it:
When using (persistent) volumes and fsGroup, the Kubelet should ensure all directories are group-executable to avoid permission issues
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Hi @mxey. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
Hostpath volumes do not support fsgroup. The issue of 2 pods specifying the same fsgroup is an unsolved issue today. It's mitigated slightly with PVCs because then the pods have to be in the same namespace and hopefully they can coordinate setting the correct fsgroup.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Sorry, I assumed silence was consent :)…
On Thu, Jan 31, 2019, 11:43 AM Tim Allclair (St. Clair) < ***@***.***> wrote: /hold We're still discussing the security implications of this. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#73533 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVKvdKHqOpLQH2FPIBLOeTEPXDrinks5vI0d4gaJpZM4aar71> .