Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure directories are executable for fsGroup #73533

Merged
merged 1 commit into from Feb 7, 2019

Conversation

@mxey
Copy link
Contributor

mxey commented Jan 30, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

When using (persistent) volumes and fsGroup, the Kubelet should ensure all directories are group-executable to avoid permission issues

Which issue(s) this PR fixes:

Fixes #67814

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Ensure directories on volumes are group-executable when using fsGroup
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 30, 2019

Hi @mxey. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mxey

This comment has been minimized.

Copy link
Contributor Author

mxey commented Jan 30, 2019

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage and removed needs-sig labels Jan 30, 2019

@k8s-ci-robot k8s-ci-robot requested review from rootfs and verult Jan 30, 2019

@mxey

This comment has been minimized.

Copy link
Contributor Author

mxey commented Jan 30, 2019

/assign @thockin

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Jan 30, 2019

/ok-to-test

This LGTM. Security want to take a look? @tallclair or delegate thereof?

@tallclair
Copy link
Member

tallclair left a comment

Are these changes applied to HostPath volumes? What happens if 2 pods mount the same volume with different fsgroups?

Show resolved Hide resolved pkg/volume/volume_linux.go
@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jan 30, 2019

Are these changes applied to HostPath volumes? What happens if 2 pods mount the same volume with different fsgroups?

Hostpath volumes do not support fsgroup. The issue of 2 pods specifying the same fsgroup is an unsolved issue today. It's mitigated slightly with PVCs because then the pods have to be in the same namespace and hopefully they can coordinate setting the correct fsgroup.

@thockin
Copy link
Member

thockin left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 31, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mxey, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tallclair

This comment has been minimized.

Copy link
Member

tallclair commented Jan 31, 2019

/hold

We're still discussing the security implications of this.

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Jan 31, 2019

@tallclair

This comment has been minimized.

Copy link
Member

tallclair commented Feb 7, 2019

/hold cancel

There are some bigger discussions that need to happen around the future of FSGroup, but I don't think we need to block this on them.

@k8s-ci-robot k8s-ci-robot merged commit 6fc9a72 into kubernetes:master Feb 7, 2019

16 checks passed

cla/linuxfoundation mxey authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@mxey mxey deleted the babiel:fix-fsgroup-directory-permissions branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.