New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make missing-directory errors non fatal #73542

Merged
merged 1 commit into from Feb 1, 2019

Conversation

@juanvallejo
Copy link
Member

juanvallejo commented Jan 30, 2019

Fixes kubernetes/kubectl#574

/kind cleanup
/sig cli

Missing directories listed in a user's PATH are no longer considered errors and are instead logged by the "kubectl plugin list" command when listing available plugins.

cc @soltysh @ahmetb

@ahmetb

This comment has been minimized.

Copy link
Member

ahmetb commented Jan 30, 2019

LGTM assuming -v=3 doesn't show to users by default.

@juanvallejo

This comment has been minimized.

Copy link
Member Author

juanvallejo commented Jan 30, 2019

LGTM assuming -v=3 doesn't show to users by default.

Nope, you explicitly have to pass --v 3 to receive this message

@juanvallejo juanvallejo force-pushed the juanvallejo:jvallejo/log-missing-dir-errors branch from 43f3bf2 to de01516 Jan 30, 2019

@soltysh

soltysh approved these changes Feb 1, 2019

Copy link
Contributor

soltysh left a comment

/lgtm
/approve
/priority important-longterm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ad58fb1 into kubernetes:master Feb 1, 2019

16 checks passed

cla/linuxfoundation juanvallejo authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@juanvallejo juanvallejo deleted the juanvallejo:jvallejo/log-missing-dir-errors branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment