New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CoreDNS version to 1.3.1 #73610

Merged
merged 1 commit into from Feb 1, 2019

Conversation

@rajansandeep
Copy link
Member

rajansandeep commented Jan 31, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Bumps the CoreDNS version to 1.3.1

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

CoreDNS is now version 1.3.1
   - A new `k8s_external` plugin that allows external zones to point to Kubernetes in-cluster services.
   - CoreDNS now checks if a zone transfer is allowed. Also allow a TTL of 0 to avoid caching in the cache plugin.
   - TTL is also applied to negative responses (NXDOMAIN, etc).
   
@rajansandeep

This comment has been minimized.

Copy link
Member Author

rajansandeep commented Jan 31, 2019

@MrHohn

MrHohn approved these changes Jan 31, 2019

Copy link
Member

MrHohn left a comment

/lgtm
/approve

@MrHohn

This comment has been minimized.

Copy link
Member

MrHohn commented Jan 31, 2019

CoreDNS is now version 1.3.1

May be worth to update release note with what is new in version 1.3.1?

@neolit123
Copy link
Member

neolit123 left a comment

/approve
/priority important-longterm
@kubernetes/sig-cluster-lifecycle-pr-reviews

let's hold for a day to give time for others to see the change.
/hold

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Jan 31, 2019

May be worth to update release note with what is new in version 1.3.1?

or at least an one line summary?

@rajansandeep

This comment has been minimized.

Copy link
Member Author

rajansandeep commented Jan 31, 2019

@MrHohn @neolit123 I've updated the release notes.

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Jan 31, 2019

thanks @rajansandeep !
@MrHohn if the cluster folder needs this ASAP please feel free to hold cancel.

@MrHohn

This comment has been minimized.

Copy link
Member

MrHohn commented Jan 31, 2019

@MrHohn if the cluster folder needs this ASAP please free to hold cancel.

I don't think that is the case so let's wait a bit on this.

@fabriziopandini

This comment has been minimized.

Copy link
Contributor

fabriziopandini commented Feb 1, 2019

/approve
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, MrHohn, neolit123, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Feb 1, 2019

ok, let's unhold.
/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit b1eae78 into kubernetes:master Feb 1, 2019

16 checks passed

cla/linuxfoundation rajansandeep authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment