Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload Windows startup scripts to GCS for CI #73650

Merged
merged 1 commit into from Feb 28, 2019

Conversation

@mtaufen
Copy link
Contributor

commented Feb 1, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Upload the Windows startup scripts to where GKE can see them, similar to COS/Ubuntu scripts.

NONE

@yujuhong @pjh FYI
@ixdy Does this look right to you?

@ixdy

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

This looks technically correct, but I'll echo the same comment I made over on kubernetes/release#662 - why is Google/GKE/GCE special here?

@mtaufen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

As soon as we can get rid of the deprecated cluster/ directory we can get rid of this too, but until then we should maintain the legacy behavior.

@mtaufen mtaufen changed the title WIP upload Windows startup scripts to GCS for CI upload Windows startup scripts to GCS for CI Feb 11, 2019

@mtaufen mtaufen force-pushed the mtaufen:windows-upload-scripts branch from 81591b6 to a655b03 Feb 11, 2019

@mtaufen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

/hold
this on the switch to 1809 same as kubernetes/release#662 (review)

@mtaufen mtaufen force-pushed the mtaufen:windows-upload-scripts branch from a655b03 to b2d5319 Feb 13, 2019

@mtaufen mtaufen force-pushed the mtaufen:windows-upload-scripts branch from b2d5319 to 7aaeb5a Feb 20, 2019

"common.psm1",
"configure.ps1",
"k8s-node-setup.psm1",
"user-profile.psm1",

This comment has been minimized.

Copy link
@pjh

pjh Feb 21, 2019

Contributor

I'm updating this directory structure (and adding a file) in #74360.

@pjh

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

Our PR to switch the test job to 1809 has been merged (kubernetes/kubernetes#74103). However, I suggest waiting for kubernetes/kubernetes#74360 to be merged and then updating this PR to reflect the files correctly - I added a testonly/ subdir and moved a couple files there.

@mtaufen mtaufen force-pushed the mtaufen:windows-upload-scripts branch from 7aaeb5a to dfded52 Feb 25, 2019

@k8s-ci-robot k8s-ci-robot removed the size/XS label Feb 25, 2019

@k8s-ci-robot k8s-ci-robot added size/M and removed needs-rebase labels Feb 25, 2019

@mtaufen mtaufen force-pushed the mtaufen:windows-upload-scripts branch from dfded52 to c0628bd Feb 25, 2019

@mtaufen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

/hold cancel
Updated for latest upstream

@mtaufen mtaufen force-pushed the mtaufen:windows-upload-scripts branch from c0628bd to 9b3926c Feb 25, 2019

@mtaufen mtaufen force-pushed the mtaufen:windows-upload-scripts branch from 9b3926c to 98edbf4 Feb 26, 2019

"configure.ps1",
"k8s-node-setup.psm1",
"testonly/install-ssh.psm1",
"testonly/user-profile.psm1",

This comment has been minimized.

Copy link
@ixdy

ixdy Feb 26, 2019

Member

in kubernetes/release#662 this doesn't have a testonly/ prefix?

This comment has been minimized.

Copy link
@mtaufen

mtaufen Feb 27, 2019

Author Contributor

Thanks! Updated that PR for this as well.

"common.psm1",
"configure.ps1",
"k8s-node-setup.psm1",
"testonly/install-ssh.psm1",

This comment has been minimized.

Copy link
@ixdy

ixdy Feb 26, 2019

Member

this isn't included in kubernetes/release#662?

This comment has been minimized.

Copy link
@mtaufen

mtaufen Feb 27, 2019

Author Contributor

Thanks! Updated that PR to include it.

@ixdy

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

/lgtm
/approve

I'm not especially a fan of adding more GKE-specific bits to the GCS path, but I guess the plan is to eventually retire cluster/.

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 27, 2019

@yujuhong

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, mtaufen, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4741785 into kubernetes:master Feb 28, 2019

16 checks passed

cla/linuxfoundation mtaufen authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.