Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --all-namespaces to kubectl delete #73716

Merged
merged 1 commit into from Feb 6, 2019

Conversation

@deads2k
Copy link
Contributor

deads2k commented Feb 4, 2019

kubectl delete should support --all-namespaces. Since we now have CRDs, wanting to delete all of a particular type is a more reasonable use-case to support. There are also edges where I want this today.

@kubernetes/sig-cli-maintainers

`kubectl delete --all-namespaces` is a recognized flag.

@enj since you hit it.

set -o pipefail

# Runs tests related to kubectl delete --all-namespaces.
run_kubectl_delete_allnamespaces_tests() {

This comment has been minimized.

@liggitt

liggitt Feb 4, 2019

Member

don't you need to call this from somewhere?

This comment has been minimized.

@deads2k

deads2k Feb 4, 2019

Author Contributor

don't you need to call this from somewhere?

Ah, I guess I did half the refactoring to match openshift.

This comment has been minimized.

@deads2k

deads2k Feb 4, 2019

Author Contributor

don't you need to call this from somewhere?

fixed

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 4, 2019

one question on the test, lgtm otherwise

@deads2k deads2k force-pushed the deads2k:delete-all branch 2 times, most recently from c0c63e1 to e004aa7 Feb 4, 2019

@enj

This comment has been minimized.

Copy link
Member

enj commented Feb 5, 2019

hack/make-rules/../../hack/verify-gofmt.sh
hack/make-rules/../../hack/verify-shellcheck.sh
/go/src/k8s.io/kubernetes/test/cmd/../../third_party/forked/shell2junit/sh2ju.sh: line 47: run_kubectl_delete_allnamespaces_tests: command not found
@RA489

This comment has been minimized.

Copy link
Contributor

RA489 commented Feb 5, 2019

@deads2k as an helper please run these:
./hack/update-gofmt.sh
./hack/verify-golint.sh
./hack/verify-shellcheck.sh

@deads2k deads2k force-pushed the deads2k:delete-all branch 4 times, most recently from fd749cf to b2e7201 Feb 5, 2019

@deads2k deads2k force-pushed the deads2k:delete-all branch from b2e7201 to 66b1f5b Feb 5, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

This comment has been minimized.

Copy link
Member

dims commented Feb 6, 2019

@liggitt looks like your comment was addressed.

LGTM 👍

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 6, 2019

/lgtm

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 6, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit fcb0d60 into kubernetes:master Feb 6, 2019

16 checks passed

cla/linuxfoundation deads2k authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented on hack/.shellcheck_failures in 66b1f5b Feb 21, 2019

:(

@@ -177,6 +177,7 @@
./test/cmd/core.sh
./test/cmd/crd.sh
./test/cmd/create.sh
./test/cmd/delete.sh

This comment has been minimized.

@fejta

fejta Feb 21, 2019

Contributor

Can you make this pass lint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.