Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: Remove kubeadm alpha preflight subcommand #73718

Merged
merged 1 commit into from Feb 5, 2019

Conversation

@fabriziopandini
Copy link
Contributor

fabriziopandini commented Feb 4, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
After #73163 merged pre-flight checks for kubeadm join are now exposed as phase, so it is possible to remove kubeadm alpha preflight and its own only subcommand kubeadm alpha preflight node

Which issue(s) this PR fixes:
Fixes:kubernetes/kubeadm#1386

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubeadm: `kubeadm alpha preflight` and `kubeadm alpha preflight node` are removed; you can now use `kubeadm join phase preflight`

/sig cluster-lifecycle
/priority backlog
@kubernetes/sig-cluster-lifecycle-pr-reviews

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member

neolit123 left a comment

thanks!
/lgtm

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Feb 4, 2019

/hold
holding because i forgot to ask - we might want a release note here, even if we are removing an alpha command, correct?

please feel free to hold cancel @fabriziopandini

@fabriziopandini

This comment has been minimized.

Copy link
Contributor Author

fabriziopandini commented Feb 4, 2019

@neolit123 good point. Added a release note
/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 1e78fec into kubernetes:master Feb 5, 2019

16 checks passed

cla/linuxfoundation fabriziopandini authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@fabriziopandini fabriziopandini deleted the fabriziopandini:remove-kubeadm-alpha-preflight branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.