Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: add a preflight check for Docker and cgroup driver #73837

Merged
merged 2 commits into from Feb 9, 2019

Conversation

@neolit123
Copy link
Member

neolit123 commented Feb 8, 2019

What this PR does / why we need it:
systemd is the recommended driver as per the setup of running
the kubelet using systemd as the init system. Add a preflight
check that throws a warning if this isn't the case.

Which issue(s) this PR fixes:

xref kubernetes/kubeadm#1394

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

kubeadm: add a preflight check that throws a warning if the cgroup driver for Docker on Linux is not "systemd" as per the k8s.io CRI installation guide.

/assign @timothysc
/cc @rosti
cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/kind bug
/priority critical-urgent

can be of kind feature too.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Feb 8, 2019

example output:

[init] Using Kubernetes version: v1.13.3
[preflight] Running pre-flight checks
	[WARNING IsDockerSystemdCheck]: detected "cgroupfs" as the Docker cgroup driver.
The recommended driver is "systemd". Please follow the guide at https://kubernetes.io/docs/setup/cri/
@yagonobre
Copy link
Member

yagonobre left a comment

Thanks @neolit123
/lgtm
/hold
feel free to unhold

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 8, 2019

@neolit123 neolit123 force-pushed the neolit123:preflight-docker-cgroup branch from db5433f to 4a0d3ea Feb 8, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 8, 2019

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Feb 8, 2019

let's have @timothysc and @rosti have a look too.

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Feb 8, 2019

/retest

@timothysc
Copy link
Member

timothysc left a comment

minor comments/nits otherwise lgtm

@mauilion - is this helpful? Or would you like to see more info?

@neolit123 neolit123 force-pushed the neolit123:preflight-docker-cgroup branch from 4a0d3ea to c03ee79 Feb 8, 2019

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Feb 8, 2019

neolit123 added some commits Feb 8, 2019

kubeadm: add a preflight check for Docker and cgroup driver
systemd is the recommended driver as per the setup of running
the kubelet using systemd as the init system. Add a preflight
check that throws a warning if this isn't the case.

@neolit123 neolit123 force-pushed the neolit123:preflight-docker-cgroup branch from c03ee79 to 3b3b79f Feb 8, 2019

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Feb 8, 2019

/retest

@timothysc

This comment has been minimized.

Copy link
Member

timothysc commented Feb 8, 2019

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Feb 8, 2019

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Feb 9, 2019

/skip

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Feb 9, 2019

/test pull-kubernetes-cross
/test pull-kubernetes-godeps

@k8s-ci-robot k8s-ci-robot merged commit a1cc48b into kubernetes:master Feb 9, 2019

14 checks passed

cla/linuxfoundation neolit123 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.