New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis:core:validation: remove unused, changes to idiomatic go #73877

Merged
merged 1 commit into from Feb 11, 2019

Conversation

@droslean
Copy link
Contributor

droslean commented Feb 9, 2019

Remove unexported unused functions fsResourceIsEphemeralStorage(),isLocalStorageResource().
Replace an unnecessary loop to idiomatic go way.

/kind cleanup

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 9, 2019

@droslean: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 9, 2019

Hi @droslean. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@droslean

This comment has been minimized.

Copy link
Contributor Author

droslean commented Feb 9, 2019

/release-note-none

@droslean

This comment has been minimized.

Copy link
Contributor Author

droslean commented Feb 9, 2019

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup and removed needs-kind labels Feb 9, 2019

@kargakis

This comment has been minimized.

Copy link
Member

kargakis commented Feb 9, 2019

/ok-to-test

@kargakis
Copy link
Member

kargakis left a comment

/lgtm

@kargakis

This comment has been minimized.

Copy link
Member

kargakis commented Feb 11, 2019

needs an approval

/assign @liggitt

@kargakis kargakis removed their assignment Feb 11, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 11, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@droslean

This comment has been minimized.

Copy link
Contributor Author

droslean commented Feb 11, 2019

/test pull-kubernetes-integration

@droslean

This comment has been minimized.

Copy link
Contributor Author

droslean commented Feb 11, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot k8s-ci-robot merged commit f7c4389 into kubernetes:master Feb 11, 2019

16 checks passed

cla/linuxfoundation droslean authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment