New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up excess code #73908

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@xichengliudui
Copy link
Contributor

xichengliudui commented Feb 11, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
clean up excess code

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 11, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xichengliudui
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: liggitt

If they are not already assigned, you can assign the PR to them by writing /assign @liggitt in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from caesarxuchao and therc Feb 11, 2019

@k8s-ci-robot k8s-ci-robot added sig/apps and removed needs-sig labels Feb 11, 2019

@xichengliudui

This comment has been minimized.

Copy link
Contributor Author

xichengliudui commented Feb 11, 2019

/assign @liggitt

@xichengliudui

This comment has been minimized.

Copy link
Contributor Author

xichengliudui commented Feb 11, 2019

/retest

clean up excess code
update pull request

@xichengliudui xichengliudui force-pushed the xichengliudui:cleanupcode branch from 1a643bb to 59a68ba Feb 11, 2019

@xichengliudui

This comment has been minimized.

Copy link
Contributor Author

xichengliudui commented Feb 11, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 11, 2019

@xichengliudui: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-build 59a68ba link /test pull-kubernetes-bazel-build
pull-kubernetes-bazel-test 59a68ba link /test pull-kubernetes-bazel-test
pull-kubernetes-e2e-gce 59a68ba link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-gce-device-plugin-gpu 59a68ba link /test pull-kubernetes-e2e-gce-device-plugin-gpu
pull-kubernetes-e2e-gce-100-performance 59a68ba link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-node-e2e 59a68ba link /test pull-kubernetes-node-e2e
pull-kubernetes-integration 59a68ba link /test pull-kubernetes-integration
pull-kubernetes-kubemark-e2e-gce-big 59a68ba link /test pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-typecheck 59a68ba link /test pull-kubernetes-typecheck
pull-kubernetes-verify 59a68ba link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -177,10 +177,9 @@ func Convert_v1_Deployment_To_apps_Deployment(in *appsv1.Deployment, out *apps.D
if revision, _ := in.Annotations[appsv1.DeprecatedRollbackTo]; revision != "" {
if revision64, err := strconv.ParseInt(revision, 10, 64); err != nil {
return fmt.Errorf("failed to parse annotation[%s]=%s as int64: %v", appsv1.DeprecatedRollbackTo, revision, err)
} else {
out.Spec.RollbackTo = new(apps.RollbackConfig)
out.Spec.RollbackTo.Revision = revision64

This comment has been minimized.

@liggitt

liggitt Feb 11, 2019

Member

revision64 is only defined in the scope of the if/else block

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 11, 2019

Thanks for the PR, but the revision64/value64 values are only defined in the scope of the if/else block. I think the structure of this is fine as-is.

/close

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 11, 2019

@liggitt: Closed this PR.

In response to this:

Thanks for the PR, but the revision64/value64 values are only defined in the scope of the if/else block. I think the structure of this is fine as-is.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment