Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upclean up excess code #73908
Conversation
This comment has been minimized.
This comment has been minimized.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xichengliudui If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
requested review from
caesarxuchao
and
therc
Feb 11, 2019
k8s-ci-robot
added
sig/apps
and removed
needs-sig
labels
Feb 11, 2019
This comment has been minimized.
This comment has been minimized.
/assign @liggitt |
k8s-ci-robot
assigned
liggitt
Feb 11, 2019
This comment has been minimized.
This comment has been minimized.
/retest |
xichengliudui
force-pushed the
xichengliudui:cleanupcode
branch
from
1a643bb
to
59a68ba
Feb 11, 2019
This comment has been minimized.
This comment has been minimized.
/retest |
This comment has been minimized.
This comment has been minimized.
@xichengliudui: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
liggitt
reviewed
Feb 11, 2019
@@ -177,10 +177,9 @@ func Convert_v1_Deployment_To_apps_Deployment(in *appsv1.Deployment, out *apps.D | |||
if revision, _ := in.Annotations[appsv1.DeprecatedRollbackTo]; revision != "" { | |||
if revision64, err := strconv.ParseInt(revision, 10, 64); err != nil { | |||
return fmt.Errorf("failed to parse annotation[%s]=%s as int64: %v", appsv1.DeprecatedRollbackTo, revision, err) | |||
} else { | |||
out.Spec.RollbackTo = new(apps.RollbackConfig) | |||
out.Spec.RollbackTo.Revision = revision64 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks for the PR, but the revision64/value64 values are only defined in the scope of the if/else block. I think the structure of this is fine as-is. /close |
k8s-ci-robot
closed this
Feb 11, 2019
This comment has been minimized.
This comment has been minimized.
@liggitt: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
xichengliudui commentedFeb 11, 2019
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
clean up excess code
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: