Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve windows home directory selection #73923
What type of PR is this?
What this PR does / why we need it:
Improves the selected home directory on windows, while maintaining compatibility with existing configurations that already point at a location containing a kubeconfig file, or a user-writeable directory.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Feb 11, 2019
referenced this pull request
Feb 14, 2019
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: liggitt
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Feb 16, 2019
If we're worried about back compat, then I would simplify this to:
Even on systems that are set up with temporary profiles that don't persist state across logins - USERPROFILE will be writeable as key apps use well-known folders under it https://docs.microsoft.com/en-us/windows/desktop/shell/knownfolderid