New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nvidia-gpu-device-plugin addon. #73940

Open
wants to merge 1 commit into
base: master
from

Conversation

@jiayingz
Copy link
Member

jiayingz commented Feb 11, 2019

This includes changes from GoogleCloudPlatform/container-engine-accelerators#102

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/sig node

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@neolit123
Copy link
Member

neolit123 left a comment

@jiayingz could you please add a line or two about why this addon is being updated?
...for the PR archive. thanks.

/kind cleanup
/priority backlog

@jiayingz

This comment has been minimized.

Copy link
Member Author

jiayingz commented Feb 12, 2019

/test pull-kubernetes-node-e2e
/test pull-kubernetes-integration

@jiayingz

This comment has been minimized.

Copy link
Member Author

jiayingz commented Feb 12, 2019

/assign @vishh @dchen1107

@vishh

This comment has been minimized.

Copy link
Member

vishh commented Feb 13, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 13, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 13, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiayingz, vishh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dchen1107

If they are not already assigned, you can assign the PR to them by writing /assign @dchen1107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment