New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function comment to consistent with its name #73949

Merged
merged 1 commit into from Feb 12, 2019

Conversation

@xichengliudui
Copy link
Contributor

xichengliudui commented Feb 12, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fix function comment to consistent with its name

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
Fix function comment to consistent with its name
update pull request

update pull request
@xichengliudui

This comment has been minimized.

Copy link
Contributor Author

xichengliudui commented Feb 12, 2019

/assign @yujuhong

@xichengliudui

This comment has been minimized.

Copy link
Contributor Author

xichengliudui commented Feb 12, 2019

/assign @mkumatag

@@ -280,7 +280,7 @@ func getPodDNSType(pod *v1.Pod) (podDNSType, error) {
return podDNSCluster, fmt.Errorf(fmt.Sprintf("invalid DNSPolicy=%v", dnsPolicy))
}

// Merge DNS options. If duplicated, entries given by PodDNSConfigOption will
// mergeDNSOptions merge DNS options. If duplicated, entries given by PodDNSConfigOption will

This comment has been minimized.

@mkumatag

mkumatag Feb 12, 2019

Member

s/merge/merges/

This comment has been minimized.

@xichengliudui

xichengliudui Feb 12, 2019

Author Contributor

Thank you very much. I have modified it, is that right?

This comment has been minimized.

@mkumatag
@@ -337,7 +337,7 @@ func (g *GenericPLEG) cacheEnabled() bool {
return g.cache != nil
}

// Preserve an older cached status' pod IP if the new status has no pod IP
// getPodIP preserve an older cached status' pod IP if the new status has no pod IP

This comment has been minimized.

@mkumatag

mkumatag Feb 12, 2019

Member

s/preserve/preserves/

This comment has been minimized.

@xichengliudui

xichengliudui Feb 12, 2019

Author Contributor

thanks!

@xichengliudui xichengliudui force-pushed the xichengliudui:fixerrornote branch 2 times, most recently from 654a46c to 5dd26ec Feb 12, 2019

@mkumatag

This comment has been minimized.

Copy link
Member

mkumatag commented Feb 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 12, 2019

@xichengliudui

This comment has been minimized.

Copy link
Contributor Author

xichengliudui commented Feb 12, 2019

@mkumatag thanks.

@mkumatag

This comment has been minimized.

Copy link
Member

mkumatag commented Feb 12, 2019

@mkumatag thanks.

@xichengliudui Now you need to chase the maintainers to get approved tag ;) all the best :)

@xichengliudui

This comment has been minimized.

Copy link
Contributor Author

xichengliudui commented Feb 12, 2019

/retest

1 similar comment
@xichengliudui

This comment has been minimized.

Copy link
Contributor Author

xichengliudui commented Feb 12, 2019

/retest

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Feb 12, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xichengliudui, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member

neolit123 left a comment

/kind cleanup
/priority backlog
/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 12, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 12, 2019

@xichengliudui: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized 5dd26ec link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 727dd66 into kubernetes:master Feb 12, 2019

16 of 17 checks passed

pull-kubernetes-local-e2e-containerized Job failed.
Details
cla/linuxfoundation xichengliudui authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment