Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cp time stamp is in the future error #73982

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@tanshanshan
Copy link
Member

commented Feb 13, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #73956

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes invalid "time stamp is the future" error when kubectl cp-ing a file
@tanshanshan

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2019

/test pull-kubernetes-e2e-gce

@fejta-bot

This comment has been minimized.

Copy link

commented May 16, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@fejta-bot

This comment has been minimized.

Copy link

commented Jun 15, 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@odinuge

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

/test pull-kubernetes-e2e-gce

@odinuge

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

/remove-lifecycle rotten

@odinuge

odinuge approved these changes Jul 2, 2019

Copy link
Member

left a comment

Thanks for the fix!

This sounds reasonable to me. Copying files should not preserve the modified time. This is also an annoying problem when clocks are off sync too (ref. the issue)

LGTM

@odinuge

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

/cc @apelisse

Also, maybe this deserves a release note since it fixes a user facing problem? @tanshanshan

@k8s-ci-robot k8s-ci-robot requested a review from apelisse Jul 2, 2019

@apelisse

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Also, maybe this deserves a release note since it fixes a user facing problem?

I think I agree with that.

/lgtm
/approve

@apelisse

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

/hold

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, tanshanshan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tanshanshan

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

@odinuge ,@apelisse
PTAL
I added release note

@apelisse

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

@tanshanshan I've updated the release note slightly, feel free to edit again or just /hold cancel when you're happy with it.

@tanshanshan

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 75a39b7 into kubernetes:master Jul 3, 2019

18 checks passed

cla/linuxfoundation tanshanshan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Context retired. Status moved to "pull-kubernetes-dependencies".
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Context retired without replacement.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.