Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI Inline Volume Implementation #74086

Merged
merged 3 commits into from Mar 8, 2019

Conversation

@vladimirvivien
Copy link
Member

vladimirvivien commented Feb 14, 2019

/kind api-change
/kind feature

What this PR does / why we need it:
This PR only implements the API and Kubelet/Driver changes for CSI inline volume.

See also

Old PRs (for historical context)
#67452, #68232

Release note:

Alpha support for ephemeral CSI inline volumes that are embedded in pod specs.

/SIG storage

@vladimirvivien

This comment has been minimized.

Copy link
Member Author

vladimirvivien commented Feb 14, 2019

/assign @liggitt
/assign @thockin

@vladimirvivien

This comment has been minimized.

Copy link
Member Author

vladimirvivien commented Feb 14, 2019

/test pull-kubernetes-bazel-test

@vladimirvivien

This comment has been minimized.

Copy link
Member Author

vladimirvivien commented Feb 15, 2019

/test pull-kubernetes-e2e-gce

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Feb 15, 2019

/assign

@liggitt liggitt added this to the v1.14 milestone Feb 15, 2019

@vladimirvivien vladimirvivien force-pushed the vladimirvivien:csi-inline-volume-api branch from ea8a64a to 0cf3e9a Feb 15, 2019

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 8, 2019

/lgtm
Remaining comments are nits and can be cleaned up later.

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 8, 2019

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 8, 2019

/priority important-soon

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 8, 2019

/hold cancel
This is a planned 1.14 feature

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Mar 8, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

5 similar comments
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Mar 8, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Mar 8, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Mar 8, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Mar 8, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Mar 8, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@vladimirvivien vladimirvivien force-pushed the vladimirvivien:csi-inline-volume-api branch from ab401ef to 923ad36 Mar 8, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 8, 2019

@vladimirvivien

This comment has been minimized.

Copy link
Member Author

vladimirvivien commented Mar 8, 2019

/test pull-kubernetes-godeps

@vladimirvivien

This comment has been minimized.

Copy link
Member Author

vladimirvivien commented Mar 8, 2019

/test pull-kubernetes-e2e-gce-csi-serial

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 8, 2019

/lgtm
The godeps job right now is pretty flaky

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 8, 2019

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 8, 2019

/retest

1 similar comment
@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 8, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 83ff0f6 into kubernetes:master Mar 8, 2019

18 checks passed

cla/linuxfoundation vladimirvivien authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@kfox1111

This comment has been minimized.

Copy link

kfox1111 commented Mar 8, 2019

Great work everyone! Congratulations! :)

@liggitt liggitt removed this from In progress in API Reviews Mar 8, 2019

return false
}
if utilfeature.DefaultFeatureGate.Enabled(features.CSIInlineVolume) {
return (spec.PersistentVolume != nil && spec.PersistentVolume.Spec.CSI != nil) ||

This comment has been minimized.

@tedyu

tedyu Mar 10, 2019

Contributor

Should spec.PersistentVolume.Spec be checked against nil ?

// AllowedCSIDrivers is a whitelist of inline CSI drivers that must be explicitly set to be embedded within a pod spec.
// An empty value means no CSI drivers can run inline within a pod spec.
// +optional
repeated AllowedCSIDriver allowedCSIDrivers = 23;

This comment has been minimized.

@tedyu

tedyu Mar 10, 2019

Contributor

Why is this placed here instead of at the end of the PodSecurityPolicySpec ?

Also, ordinal 22 is unoccupied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.