Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
kubeadm: Remove etcd members from the etcd cluster when reset the nodes #74112
What type of PR is this?
What this PR does / why we need it:
Add feature that remove etcd members from the etcd cluster when reset the control plane nodes.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Sending a PR to review.
I don't know if there is anything missing, if this workflow wrong, hope point out. Thanks.
Does this PR introduce a user-facing change?:
Hi @pytimer. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
changed the title
[WIP] kubeadm: Remove etcd members from the etcd cluster when reset the nodes
Feb 16, 2019
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Feb 22, 2019
15 of 16 checks passed
@pytimer is it possible to make it as phase, so i can clean etcd node without do kubeadm reset.
I have 3 master nodes. Then I terminated first node, and boot with same ip address. So I need to clean etcd member before do join(because there are still old members there).
@neolit123 yep. I just want to use one tool, if it has such functionality. Now it looks ugly: https://github.com/jetthoughts/infrastructure/blob/k8s-v1.14/modules/k8s_master/data/master_init.tpl.sh#L33
could you please log an k/kubeadm issue about "reset phases", we already have phases for join and init, upgrade is planned, but no plan for release yet.
It could be also implemented when do
anyway thanks for help. will wait also for reset phases.