Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate OpenAPI specs for delegated API servers #74133

Open
wants to merge 9 commits into
base: master
from

Conversation

@sttts
Copy link
Contributor

commented Feb 15, 2019

Split up the OpenAPI spec by delegated API server. Before this we did not follow the separation via delegated API servers for OpenAPI. This was tech debt we were taking along for many versions.

The consequence was that due to import restrictions, none of the staging repos (apiextensions-apiserver, kube-aggregator) could access its own OpenAPI spec directly. We need this to cleanly wire server-side-apply for CRDs #79433.

NONE
@@ -0,0 +1,2006 @@
// +build !ignore_autogenerated

This comment has been minimized.

Copy link
@roycaihw

roycaihw Feb 15, 2019

Member

we don't check-in this file for built-in APIs:

zz_generated.openapi.go

let's ignore this one to be consistent

This comment has been minimized.

Copy link
@roycaihw

roycaihw Feb 15, 2019

Member

I see. it's under k8s.io/code-generator/_examples, not k8s.io/sample-apiserver

This comment has been minimized.

Copy link
@sttts

sttts Jul 5, 2019

Author Contributor

Actually for this one (and the sample-apiserver) I want to see them checked in order to track changes due to tooling. We don't check the top-level one in because API changes easily conflict. This is not the case here.

@sttts sttts force-pushed the sttts:sttts-openapi-code-generation branch 2 times, most recently from cf3b736 to a8a40d0 Feb 18, 2019
Copy link
Contributor

left a comment

@sttts k8s.io/kube-openapi needs to be added to

- baseImportPath: "./vendor/k8s.io/apiextensions-apiserver/"
allowedImports:
- k8s.io/api
- k8s.io/apiextensions-apiserver
- k8s.io/apimachinery
- k8s.io/apiserver
- k8s.io/client-go
- k8s.io/component-base
- k8s.io/klog

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

/retest

No test logs :-/

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

@liggitt ptal

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

/retest

@@ -39,7 +39,7 @@ import (
"k8s.io/kube-openapi/pkg/util"

"k8s.io/apiextensions-apiserver/pkg/apis/apiextensions"
generatedopenapi "k8s.io/apiextensions-apiserver/pkg/generated/openapi"

This comment has been minimized.

Copy link
@yue9944882

yue9944882 Aug 16, 2019

Member

is the change of generated openapi package path intended? consider backward-compatibility?

This comment has been minimized.

Copy link
@sttts

sttts Aug 16, 2019

Author Contributor

Yes, it is. We had two specs, used the wrong, old one.

This code here is considered internal. Nothing depends on it.

@liggitt liggitt modified the milestones: v1.16, v1.17 Aug 21, 2019
@sttts sttts force-pushed the sttts:sttts-openapi-code-generation branch 4 times, most recently from 046ec05 to c7ca6d0 Aug 22, 2019
@sttts sttts force-pushed the sttts:sttts-openapi-code-generation branch from c7ca6d0 to 4274abe Aug 24, 2019
@sttts sttts force-pushed the sttts:sttts-openapi-code-generation branch from 4274abe to ea04bce Aug 24, 2019
@sttts sttts force-pushed the sttts:sttts-openapi-code-generation branch from ea04bce to 4b9ec73 Aug 24, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2019

@sttts: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-godeps a8a40d0 link /test pull-kubernetes-godeps
pull-kubernetes-conformance-kind-ipv6 4b9ec73 link /test pull-kubernetes-conformance-kind-ipv6
pull-kubernetes-e2e-gce 4b9ec73 link /test pull-kubernetes-e2e-gce
pull-kubernetes-verify 4b9ec73 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.