Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readinessProbe to CoreDNS #74137

Merged
merged 1 commit into from Feb 20, 2019

Conversation

@rajansandeep
Copy link
Member

rajansandeep commented Feb 15, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Adds a readinessProbe to CoreDNS, which should accurately represent readiness.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

CoreDNS adds readinessProbe which prevents loadbalancing to unready pods, and also allows rolling updates to work as expected.
@rajansandeep

This comment has been minimized.

Copy link
Member Author

rajansandeep commented Feb 15, 2019

@neolit123
Copy link
Member

neolit123 left a comment

SGTM
thanks @rajansandeep

/priority important-longterm
@kubernetes/sig-cluster-lifecycle-pr-reviews
comments?

httpGet:
path: /health
port: 8080
scheme: HTTP
initialDelaySeconds: 60

This comment has been minimized.

@MrHohn

MrHohn Feb 15, 2019

Member

These settings (e.g. initialDelaySeconds, successThreshold) were for livenessProbe. We would probably like to keep them and add another set of settings for readinessProbe?

This comment has been minimized.

@rajansandeep

rajansandeep Feb 15, 2019

Author Member

oops, yes, those settings were meant to remain for livenessProbe
I'll update.

@@ -147,6 +147,11 @@ spec:
timeoutSeconds: 5
successThreshold: 1
failureThreshold: 5
readinessProbe:

This comment has been minimized.

@MrHohn

MrHohn Feb 15, 2019

Member

Might need to fix the indentation.

This comment has been minimized.

@rajansandeep

rajansandeep Feb 19, 2019

Author Member

done!

@rajansandeep rajansandeep force-pushed the rajansandeep:readinessprobe branch from 0a1b151 to 37c3d68 Feb 19, 2019

@neolit123
Copy link
Member

neolit123 left a comment

/approve

@MrHohn

MrHohn approved these changes Feb 19, 2019

Copy link
Member

MrHohn left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, neolit123, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Feb 19, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7b203c6 into kubernetes:master Feb 20, 2019

17 checks passed

cla/linuxfoundation rajansandeep authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped
tide In merge pool.
Details
@MrHohn

This comment has been minimized.

Copy link
Member

MrHohn commented Feb 21, 2019

Seems like a couple of DNS tests started failing after this: https://k8s-testgrid.appspot.com/sig-network-gce#gci-gce-serial

@rajansandeep

This comment has been minimized.

Copy link
Member Author

rajansandeep commented Feb 21, 2019

@MrHohn I'll take a look.

dghubble added a commit to poseidon/terraform-render-bootkube that referenced this pull request Feb 23, 2019

rfranzke added a commit to gardener/gardener that referenced this pull request Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.