Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nested loop in pruneInitContainersBeforeStart of kuberuntime_container #74175

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@tedyu
Copy link
Contributor

commented Feb 17, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Currently we use nested loop in pruneInitContainersBeforeStart to prune InitContainer. This unnecessarily loops podStatus.ContainerStatuses where there is no single match in initContainerNames Set.
This PR removes the outer loop. We can use a map to record the number of times any initContainer name has been seen and prune accordingly.

Same change is applied to purgeInitContainers as well.

Special notes for your reviewer:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2019

Hi @tedyu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tedyu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tallclair

If they are not already assigned, you can assign the PR to them by writing /assign @tallclair in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Feb 18, 2019

@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2019

1 similar comment
@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

/ok-to-test

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 26, 2019

@tedyu: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu b78b102 link /test pull-kubernetes-e2e-gce-device-plugin-gpu
pull-kubernetes-bazel-build b78b102 link /test pull-kubernetes-bazel-build
pull-kubernetes-node-e2e b78b102 link /test pull-kubernetes-node-e2e
pull-kubernetes-bazel-test b78b102 link /test pull-kubernetes-bazel-test
pull-kubernetes-e2e-gce b78b102 link /test pull-kubernetes-e2e-gce
pull-kubernetes-integration b78b102 link /test pull-kubernetes-integration
pull-kubernetes-e2e-gce-100-performance b78b102 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-kubemark-e2e-gce-big b78b102 link /test pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-typecheck b78b102 link /test pull-kubernetes-typecheck
pull-kubernetes-verify b78b102 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.