Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSINodeInfo and CSIDriver Controller Changes #74283

Merged
merged 7 commits into from Mar 5, 2019

Conversation

@xing-yang
Copy link
Contributor

xing-yang commented Feb 20, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR includes the controller side changes to move CSINodeInfo and CSIDriver to v1beta1 core storage APIs. It depends on the PR for API changes:
#73883

Which issue(s) this PR fixes:

Fixes #
kubernetes/enhancements#770
kubernetes/enhancements#603

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Transition CSINodeInfo and CSIDriver alpha CRDs to in-tree CSINode and CSIDriver core storage v1beta1 APIs.
ACTION REQUIRED: the alpha CRDs are no longer used and drivers will need to be updated to use the beta APIs.
The support for `_` in the CSI driver name will be dropped as the CSI Spec does not allow that. 
@fedebongio

This comment has been minimized.

Copy link
Contributor

fedebongio commented Feb 21, 2019

/cc @cheftako

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 4, 2019

/lgtm cancel

@davidz627

This comment has been minimized.

Copy link
Contributor

davidz627 commented Mar 4, 2019

/lgtm

} else {
// Found a driver with name csiDriverName
// Set hasModified to true because it will be removed
hasModified = true

This comment has been minimized.

@msau42

msau42 Mar 4, 2019

Member

Can you also add a test case for this?

This comment has been minimized.

@xing-yang

xing-yang Mar 4, 2019

Author Contributor

Sure

@davidz627

This comment has been minimized.

Copy link
Contributor

davidz627 commented Mar 4, 2019

/hold cancel
/lgtm cancel
until test is added. Xing, please just squash commits as they were before after adding the test as well.

@xing-yang xing-yang force-pushed the xing-yang:csi_crd_controller branch from fbd14c6 to a8a5190 Mar 4, 2019

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 4, 2019

Can you also clarify in the release notes, that the it's the CSINodeInfo and CSIDriver alpha CRDs.

Also add "ACTION REQUIRED" at the beginning and mention that the alpha CRDs are no longer used and drivers will need to be updated to use the beta APIs.

@xing-yang

This comment has been minimized.

Copy link
Contributor Author

xing-yang commented Mar 5, 2019

/test pull-kubernetes-integration

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 5, 2019

/retest

xing-yang added some commits Feb 20, 2019

CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
#73883

@xing-yang xing-yang force-pushed the xing-yang:csi_crd_controller branch from a8a5190 to d69e0ff Mar 5, 2019

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 5, 2019

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 5, 2019

/test pull-kubernetes-integration

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 5, 2019

/test pull-kubernetes-e2e-gce

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 5, 2019

@xing-yang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-csi-serial 286372d link /test pull-kubernetes-e2e-gce-csi-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Mar 5, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 6c31101 into kubernetes:master Mar 5, 2019

17 checks passed

cla/linuxfoundation xing-yang authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.