Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scanning of failed targets #74306

Merged
merged 1 commit into from Feb 22, 2019

Conversation

@jsafrane
Copy link
Member

commented Feb 20, 2019

If a iSCSI target is down while a volume is attached, reading from /sys/class/iscsi_host/host415/device/session383/connection383:0/iscsi_connection/connection383:0/address fails with an error. Kubelet should assume that such target is not available / logged in and try to relogin. Eventually, if such error persists, it should continue mounting the volume if the other paths are healthy instead of failing whole WaitForAttach().

What type of PR is this?
/kind bug

Which issue(s) this PR fixes:

Fixes #74305

Does this PR introduce a user-facing change?:

Fixed scanning of failed iSCSI targets.
If a iSCSI target is down while a volume is attached, reading from
/sys/class/iscsi_host/host415/device/session383/connection383:0/iscsi_connection/connection383:0/address
fails with an error. Kubelet should assume that such target is not
available / logged in and try to relogin. Eventually, if such error
persists, it should continue mounting the volume if the other
paths are healthy instead of failing whole WaitForAttach().
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@humblec

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

@jsafrane Thanks .

@humblec

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

/lgtm

@humblec

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

@redbaron @bswartz considering this is a regression and impact is high, I am getting this in without delay. However please feel free to share your thoughts if any.

@k8s-ci-robot k8s-ci-robot merged commit ad1e021 into kubernetes:master Feb 22, 2019
16 checks passed
16 checks passed
cla/linuxfoundation jsafrane authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped
tide In merge pool.
Details
k8s-ci-robot added a commit that referenced this pull request Mar 28, 2019
…06-upstream-release-1.13

Automated cherry pick of #74306: Fix scanning of failed targets
k8s-ci-robot added a commit that referenced this pull request Apr 30, 2019
…06-upstream-release-1.12

Automated cherry pick of #74306: Fix scanning of failed targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.