Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cache size to signal undecorated storage #74321

Merged

Conversation

@yastij
Copy link
Member

commented Feb 20, 2019

What type of PR is this?

What this PR does / why we need it:

As part of kubernetes/enhancements#383 we need to be able to signal if storage is decorated with cacher or not through external parameters (e.g. watch cache size). This enables it for events and keeps the default behavior (disable watch cache for events by default)

Which issue(s) this PR fixes:

Fixes #74271

Special notes for your reviewer:

/assign @wojtek-t

Does this PR introduce a user-facing change?:

watch can now be enabled  for events using the flag --watch-cache-sizes on kube-apiserver
@yastij

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2019

/kind feature
/priority important-soon
/sig api-machinery

@k8s-ci-robot k8s-ci-robot requested review from deads2k and enj Feb 20, 2019

@yastij yastij force-pushed the yastij:signal-undecorated-storage-event branch from 4639ae9 to 47ac4a7 Feb 20, 2019

@yastij yastij changed the title WIP: use cache size to signal undecorated storage use cache size to signal undecorated storage Feb 20, 2019

@yastij yastij force-pushed the yastij:signal-undecorated-storage-event branch 2 times, most recently from 4c79641 to e268ce5 Feb 20, 2019

@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

/cc @jingyih

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

@fedebongio: GitHub didn't allow me to request PR reviews from the following users: jingyih.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jingyih

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yliaog

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

/cc

@k8s-ci-robot k8s-ci-robot requested a review from yliaog Feb 21, 2019

@yastij

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2019

fyi @liggitt

@yastij yastij force-pushed the yastij:signal-undecorated-storage-event branch from e268ce5 to cdd014b Feb 24, 2019

@yastij

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

/retest

@yastij yastij force-pushed the yastij:signal-undecorated-storage-event branch 2 times, most recently from a1045a1 to 1024adc Mar 18, 2019

@yastij yastij force-pushed the yastij:signal-undecorated-storage-event branch from 1024adc to 8261d3d Mar 19, 2019

@yastij

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

@wojtek-t @liggitt - this should be fine now. Setting watch cache’s capacity to 0 signals an undecorated storage.

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 22, 2019

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ec64aef into kubernetes:master Mar 24, 2019

17 checks passed

cla/linuxfoundation yastij authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.