Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet service links error #74529

Merged
merged 2 commits into from Mar 5, 2019

Conversation

@liggitt
Copy link
Member

commented Feb 25, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:

  • reverts kubelet-side defaulting added in #73413
  • returns an error if a nil enableServiceLinks pod spec value is encountered by the kubelet, rather than a panic

xref #71749

Does this PR introduce a user-facing change?:

Fixes panic if a kubelet is run against an older kube-apiserver

/sig node
/cc @dims @tallclair @joejulian

@k8s-ci-robot k8s-ci-robot requested a review from dims Feb 25, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

@liggitt: GitHub didn't allow me to request PR reviews from the following users: joejulian.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it:

  • reverts kubelet-side defaulting added in #73413
  • returns an error if a nil enableServiceLinks pod spec value is encountered by the kubelet, rather than a panic

Does this PR introduce a user-facing change?:

Fixes panic if a kubelet is run against an older kube-apiserver

/sig node
/cc @dims @tallclair @joejulian

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added this to the v1.14 milestone Mar 5, 2019
@liggitt

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

ping @dims / @tallclair

@dims

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

/lgtm

Thanks for taking care of this @liggitt. Do we have any CI jobs that test this scenario? (curious)

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

Do we have any CI jobs that test this scenario? (curious)

we don't have CI jobs that set up unsupported configurations that that I know of

@k8s-ci-robot k8s-ci-robot merged commit 0a4308f into kubernetes:master Mar 5, 2019
12 of 16 checks passed
12 of 16 checks passed
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@liggitt liggitt deleted the liggitt:kubelet-service-links-error branch Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.