Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi: remove postprocessing for old paths, deprecated in 1.9 #74596

Merged
merged 2 commits into from Feb 28, 2019

Conversation

@sttts
Copy link
Contributor

sttts commented Feb 26, 2019

The kube-apiserver OpenAPI definitions with the prefix "io.k8s.kubernetes.pkg" (deprecated since 1.9) have been removed.
@sttts

This comment has been minimized.

Copy link
Contributor Author

sttts commented Feb 26, 2019

/assign @mbohlool

@mbohlool

This comment has been minimized.

Copy link
Member

mbohlool commented Feb 26, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 26, 2019

@sttts

This comment has been minimized.

Copy link
Contributor Author

sttts commented Feb 28, 2019

/assign @liggitt

This is formally an API change. Please take a look.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 28, 2019

/approve

suggest being specific in the release note about the old definition prefix that was removed

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts

This comment has been minimized.

Copy link
Contributor Author

sttts commented Feb 28, 2019

Made the release-notes more specific.

@k8s-ci-robot k8s-ci-robot merged commit e476ab6 into kubernetes:master Feb 28, 2019

16 checks passed

cla/linuxfoundation sttts authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.