Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable StorageObjectInUseProtection by default #74610

Merged
merged 1 commit into from Apr 16, 2019

Conversation

@oomichi
Copy link
Member

commented Feb 26, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

StorageObjectInUseProtection plugin of admission controller adds
the flag kubernetes.io/pvc-protection or kubernetes.io/pv-protection
to newly created PVCs or PV. In case a user deletes a PVC or PV the PVC
or PV is not removed until the finalizer is removed from the PVC or PV
by PVC or PV Protection Controller.
We are testing this plugin on the e2e tests of "PV Protection" because
most setup scripts enable that like:

  • cluster/centos/config-default.sh: Enabled
  • cluster/gce/config-default.sh: Enabled
  • cluster/gce/config-test.sh: Enabled
  • cluster/kubemark/gce/config-default.sh: Enabled
  • hack/local-up-cluster.sh: Enabled
  • cluster/juju/layers/kubernetes-master/reactive/kubernetes_master.py: Disabled

As we are testing it normally, it is nice to enable the plugin by default.

Which issue(s) this PR fixes:

Fixes #74038

Does this PR introduce a user-facing change?:

StorageObjectInUseProtection admission plugin is additionally enabled by default.
So default enabled admission plugins are now `NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota,StorageObjectInUseProtection`. Please note that if you previously had not set the `--admission-control` flag, your cluster behavior may change (to be more standard).
Enable StorageObjectInUseProtection by default
StorageObjectInUseProtection plugin of admission controller adds
the flag `kubernetes.io/pvc-protection` or `kubernetes.io/pv-protection`
to newly created PVCs or PV. In case a user deletes a PVC or PV the PVC
or PV is not removed until the finalizer is removed from the PVC or PV
by PVC or PV Protection Controller.
We are testing this plugin on the e2e tests of "PV Protection" because
most setup scripts enable that like:

* cluster/centos/config-default.sh: Enabled
* cluster/gce/config-default.sh: Enabled
* cluster/gce/config-test.sh: Enabled
* cluster/kubemark/gce/config-default.sh: Enabled
* hack/local-up-cluster.sh: Enabled
* cluster/juju/layers/kubernetes-master/reactive/kubernetes_master.py: Disabled

As we are testing it normally, it is nice to enable the plugin by
default.
@oomichi

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

/test pull-kubernetes-e2e-gce-100-performance

@oomichi

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

/sig storage
/cc @msau42
/cc @gnufied

This comes from #74043

@k8s-ci-robot k8s-ci-robot requested review from gnufied and msau42 Feb 26, 2019

@cblecker cblecker removed their request for review Feb 27, 2019

@roycaihw

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

/assign @lavalamp

@msau42

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

/lgtm

@oomichi

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

@lavalamp Could you take a look at this?

@dims

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

/assign @sttts
/approve
/lgtm

This has lgtm from sig storage folks too, @sttts can you please take a peek?

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 9, 2019

@sttts

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, oomichi, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 98b6f35 into kubernetes:master Apr 16, 2019

17 checks passed

cla/linuxfoundation oomichi authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Context retired. Status moved to "pull-kubernetes-dependencies".
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.