Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the out-of-tree PV labeler controller #74615

Merged
merged 1 commit into from Mar 5, 2019

Conversation

andrewsykim
Copy link
Member

@andrewsykim andrewsykim commented Feb 26, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Removes the PersistentVolume labeler controller. This is a controller that runs as part of the CCM (i.e. meant for out-of-tree providers). With Initializer support removed for v1.14, this controller is now effectively useless because it would only check for PVs with initializers enabled.

Some justifications for this change:

  • we could not find any provider that relied on this controller (because they never created the InitializerConfiguration resource for PVs). For the few out-of-tree providers that have reported usage of this feature, we added corresponding volumes to the in-tree admission controller (vSphere Applies zone labels to newly created vsphere volumes #72687 & Cinder Add Cinder to PersistentVolumeLabel Admission Controller #73102)
  • This controller also has some serious bugs and lacked feature parity with the in-tree PersistentVolumeLabel admission controller. The most notable is the fact that the out-of-tree PVL controller would apply failure domain labels to all PVs as long as the cloud provider implemented GetLabelsForVolume. This is a wrong assumption (at least in comparison to the in-tree admission controller) and could result in a segfault.
  • Longer term, we want to only be using PV.NodeAffinity rather than labels for zone topology scheduling. SIG Cloud Provider & SIG Storage will be working on a longer-term out-of-tree solution for this in v1.15.

Which issue(s) this PR fixes:
Part of kubernetes/cloud-provider#4

Special notes for your reviewer:
More discussions around the intentions of this PR in kubernetes/cloud-provider#4

SIG cloud provider mailing list thread: https://groups.google.com/forum/#!topic/kubernetes-sig-cloud-provider/jZUB-Qk4S-M

Does this PR introduce a user-facing change?:

Remove the out-of-tree PersistentVolumeLabel controller because it cannot run without Initializers (removed in v1.14). If you are using AWS EBS, GCE PD, Azure Disk, Cinder Disk or vSphere volumes and rely on zone labels, then enable the `PersistentVolumeLabel` admission controller in the `kube-apiserver` in the `--enable-admission-plugins` flag. 

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 26, 2019
@andrewsykim
Copy link
Member Author

/sig storage
/sig cloudprovider

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 26, 2019
@andrewsykim
Copy link
Member Author

/area cloudprovider
/priorty important-soon

@andrewsykim
Copy link
Member Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 26, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2019
@andrewsykim
Copy link
Member Author

/assign @dims @msau42 @liggitt

@dims
Copy link
Member

dims commented Feb 26, 2019

/approve
/lgtm

(cross my fingers about the CI jobs!)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2019
@andrewsykim
Copy link
Member Author

/milestone v1.14

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Feb 27, 2019
@roycaihw
Copy link
Member

/assign @cheftako

@liggitt
Copy link
Member

liggitt commented Mar 4, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants