Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed alpha kubeconfig command #74628

Merged
merged 1 commit into from Feb 27, 2019

Conversation

@hpandeycodeit
Copy link
Contributor

hpandeycodeit commented Feb 26, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This removes the alpha kubeconfig command as discussed in #1381

Which issue(s) this PR fixes:

Fixes # 1381

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 26, 2019

Hi @hpandeycodeit. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123
Copy link
Member

neolit123 left a comment

thank you for this PR @hpandeycodeit !

/priority important-longterm

before running CI tests please call ./hack/update-bazel.sh and include the changes in the same single commit. (git push -f works for that).

also see my note about .gitignore.
thanks.

@kubernetes/sig-cluster-lifecycle-pr-reviews

.gitignore Outdated
@@ -130,3 +130,4 @@ zz_generated_*_test.go

# generated by verify-godeps.sh
vendordiff.patch
/.metadata/

This comment has been minimized.

@neolit123

neolit123 Feb 27, 2019

Member

we shouldn't touch the .gitignore file as part of this PR.

This comment has been minimized.

@hpandeycodeit

hpandeycodeit Feb 27, 2019

Author Contributor

I have reverted it.

@liggitt liggitt removed their request for review Feb 27, 2019

@hpandeycodeit hpandeycodeit force-pushed the hpandeycodeit:alpha_kubeconf branch from 02cd588 to 94b5945 Feb 27, 2019

@hpandeycodeit

This comment has been minimized.

Copy link
Contributor Author

hpandeycodeit commented Feb 27, 2019

@neolit123 Thanks! I have updated the commit with the ./hack/update-bazel.sh

@neolit123
Copy link
Member

neolit123 left a comment

thanks for the update.
/ok-to-test
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hpandeycodeit, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yagonobre
Copy link
Member

yagonobre left a comment

Thanks @hpandeycodeit
/lgtm

@yagonobre

This comment has been minimized.

Copy link
Member

yagonobre commented Feb 27, 2019

@hpandeycodeit I found a minor typo on release note depricated -> deprecated
/hold

@hpandeycodeit

This comment has been minimized.

Copy link
Contributor Author

hpandeycodeit commented Feb 27, 2019

@yagonobre Thanks for pointing it out. I have updated the release note.

@yagonobre

This comment has been minimized.

Copy link
Member

yagonobre commented Feb 27, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 7053e43 into kubernetes:master Feb 27, 2019

16 checks passed

cla/linuxfoundation hpandeycodeit authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@hpandeycodeit

This comment has been minimized.

Copy link
Contributor Author

hpandeycodeit commented Feb 27, 2019

Thank you @yagonobre @neolit123 !! :)

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Mar 6, 2019

@hpandeycodeit
we had to revert this PR since some users complained about the removal of the command.
we are going to look at this command again in 1.15.

can you please change the release note to NONE

instead of:

"kubeadm alpha kubeconfig" command is deprecated.
"kubeadm init phase kubeconfig admin" can be used instead to create kubeconfig files

thanks!

@hpandeycodeit

This comment has been minimized.

Copy link
Contributor Author

hpandeycodeit commented Mar 6, 2019

@neolit123 done. So that means this will remain for a while or we are completely reverting it back?

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Mar 7, 2019

thanks.
it will remain for a while and we need to decide what to do with it in the 1.15 cycle as it's under "alpha".

subramanian-neelakantan pushed a commit to subramanian-neelakantan/kubernetes that referenced this pull request Mar 7, 2019

Revert "Merge pull request kubernetes#74628 from hpandeycodeit/alpha_…
…kubeconf"

This reverts commit 7053e43, reversing
changes made to d58ff3b.

subramanian-neelakantan pushed a commit to subramanian-neelakantan/kubernetes that referenced this pull request Mar 7, 2019

Merge pull request kubernetes#75056 from timothysc/configuser
Revert "Merge pull request kubernetes#74628 from hpandeycodeit/alpha_kubeconf"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.