Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Update to use golang 1.12 #74632
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
referenced this pull request
Feb 27, 2019
from #74412 (comment):
1 similar comment
NOTE: those appear to be normal flakes, not related to this PR, but the
and of course govet is right about the kubeadm embedding of a GVKed config in another GVKed "situation". i've mentioned this is a bad idea, at least once.
the rest of the errors seem easier to manage.
Mar 1, 2019
16 checks passed
This was referenced
Mar 4, 2019
So at this point I'm not seeing a "no, revert, go1.12 broke things" but neither am I seeing a "yes, things look green since we've moved to go1.12". At the moment I'm inclined to wait and see.
Both https://testgrid.k8s.io/sig-release-master-informing#gce-master-scale-performance and https://testgrid.k8s.io/sig-release-master-informing#gce-master-scale-correctness are directly affected by kubernetes/test-infra#11594.
https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-scale-correctness/219 - most recent run was green