Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Use EPOLL_CLOEXEC to prevent fd leaks. #74691
What type of PR is this?
What this PR does / why we need it:
Use EPOLL_CLOEXEC to prevent fd leaks.
Which issue(s) this PR fixes:
Special notes for your reviewer:
There's still an issue with fsnotify which is used in other places.
Does this PR introduce a user-facing change?:
Hi @cpuguy83. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
Hi! Friendly reminder from your release team: we are starting the code freeze for 1.15 tomorrow EOD. Seeing some good progress here, just checking in to see if this is still planned for the 1.15 cycle? See that milestone added a couple of days ago and awaiting a LGTM. Assuming that's the case. Can I get a quick confirmation here?
apologies for the delay, for some reason this PR was lost in my review queue. i assume you were observing leaks from this area, but its not clear at what rate? we should have metrics for this and i am wondering why it hasn't come up prior.
@sjenning can you take a look? i think you were the original author for using memcg notifications in this area, and it would be good for you to weigh in.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing