Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add network stats for Windows nodes and containers #74788
What type of PR is this?
What this PR does / why we need it:
Add network stats for Windows nodes and containers.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
referenced this pull request
Mar 1, 2019
I'm only seeing one network now.
That matches the adapter name from the Azure-CNI logs:
@feiskyer: The following test failed, say
yujuhong left a comment
The CRI stats path is not tested by dockershim+linux AFAIK. I can't get the presubmit containerd job to run right now, so we'll need to check if post-submit CI will be affected by this change.
Other than that, this mostly looks good with questions/comments.
The summary api test is in the node e2e suite (cannot be run by windows yet). I think we should port the test over to a regular e2e, and do some sanity check to see what metrics are present. I don't think it should block this PR, but that should be addressed afterwards.
@PatrickLang Could you open an issue for tracking this? We should enable node e2e tests for Windows.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing