Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
src/k8s.io/apiserver: Increase cert expiration histogram resolution #74806
What type of PR is this?
What this PR does / why we need it:
In environments with automated certificate rotation it is not uncommen
This patch increases the histogram resolution by adding a 30m, 1h and 2h
Which issue(s) this PR fixes:
Relates to openshift/cluster-monitoring-operator#275
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
First of all we need to save the bucket bound itself (e.g.
In addition we need to record the amount of samples for a particular bucket. Previously this was done with a simple
Nowadays Prometheus client_golang leverages atomic increments for lock free recording. For that it needs two instances of the count vector, one for hot writes and one for cold reads. Hence we now have two
// Two counts, one is "hot" for lock-free observations, the other is // "cold" for writing out a dto.Metric. It has to be an array of // pointers to guarantee 64bit alignment of the histogramCounts, see // http://golang.org/pkg/sync/atomic/#pkg-note-BUG. counts *histogramCounts
Summarizing adding 3 new buckets adds 3 bucket bound
This was referenced
Mar 1, 2019
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing