Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choice of os/arch when downloading client #74889

Merged

Conversation

@akutz
Copy link
Member

commented Mar 4, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
This patch introduces KUBERNETES_CLIENT_OS and KUBERNETES_CLIENT_ARCH to the script cluster/get-kube-binaries.sh in order to download a client that is not the OS/Arch of the host on which the script is executing.

Which issue(s) this PR fixes: NA

Special notes for your reviewer:
Related to heptio/kube-conformance#32.

Does this PR introduce a user-facing change?:

Users may now execute `get-kube-binaries.sh` to request a client for an OS/Arch unlike the one of the host on which the script is invoked.
Allow choice of os/arch when downloading client
This patch introduces `KUBERNETES_CLIENT_OS` and
`KUBERNETES_CLIENT_ARCH` to the script `cluster/get-kube-binaries.sh` in
order to download a client that is not the OS/Arch of the host on which
the script is executing.
@akutz

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2019

/test pull-kubernetes-verify

@akutz

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2019

/test pull-kubernetes-e2e-gce

1 similar comment
@akutz

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2019

/test pull-kubernetes-e2e-gce

@dougm
Copy link
Member

left a comment

/lgtm

@akutz

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

Hi @stevesloka and @johnSchnake,

This is related to heptio/kube-conformance#32, and so I was hoping one of you could please review this PR. Thank you.

@akutz

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

/assign @spiffxp

@johnSchnake

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

👍
/lgtm

@spiffxp

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

/priority important-soon
/approve
thanks for your patience

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akutz, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 657951c into kubernetes:master Mar 22, 2019

17 checks passed

cla/linuxfoundation akutz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.