Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate oom watcher not relying on cAdviosr's API any more #74942

Merged
merged 3 commits into from Apr 24, 2019

Conversation

@WanLinghao
Copy link
Member

commented Mar 5, 2019

Migrate oom watcher not relying on cAdviosr any more.
It is part of plan of removing cAdvisor from k8s.
For more informations about this plan, please refer:
#68522

/kind feature

Migrate oom watcher not relying on cAdviosr's API any more
Migrate oom watcher not relying on cAdviosr any more, it is part of plan
of removing cAdvisor from k8s.
For more informations about this plan, please refer:
#68522

@WanLinghao WanLinghao force-pushed the WanLinghao:event_replace branch from cfda1c1 to b2ce446 Mar 5, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Mar 5, 2019

@WanLinghao

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

@dashpole PTAL
I have tested this by /proc/sysrq-trigger file

@dashpole

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

It still relies on cAdvisor code, just not the event watcher interface. The title is a little bit misleading. That is totally fine for now. I especially like the separation of the watcher into linux and unsupported. Ill take another pass after the tests pass

@WanLinghao WanLinghao changed the title Migrate oom watcher not relying on cAdviosr any more Migrate oom watcher not relying on cAdviosr's API any more Mar 6, 2019

@WanLinghao

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

@dashpole Hi, the test is fine now

@dashpole

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

/lgtm

@dashpole

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

/priority important-longterm

@WanLinghao

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

@yujuhong PTAL

@WanLinghao

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

@yujuhong friendly ping

@WanLinghao

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

part of #76660

@yujuhong

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

/approve
based on @dashpole's lgtm

@WanLinghao

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

/assign vishh
for hack approve

@sttts

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

/approve

for the remaining golint exception.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, WanLinghao, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8ec6167 into kubernetes:master Apr 24, 2019

18 checks passed

cla/linuxfoundation WanLinghao authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Context retired. Status moved to "pull-kubernetes-dependencies".
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.