Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate make-symlink parameter in hyperkube #74975

Merged
merged 1 commit into from Mar 12, 2019

Conversation

@dims
Copy link
Member

dims commented Mar 5, 2019

Change-Id: I07e7f5f2a4e9050de92d3f0230dae0f869b77529

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #69896

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

--make-symlinks for hyperkube was marked hidden for a while, This flag is now deprecated and will be removed in a future release.
Deprecate make-symlink parameter in hyperkube
Change-Id: I07e7f5f2a4e9050de92d3f0230dae0f869b77529
@dims

This comment has been minimized.

Copy link
Member Author

dims commented Mar 5, 2019

/priority important-soon
/sig testing

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Mar 6, 2019

/test pull-kubernetes-local-e2e

1 similar comment
@dims

This comment has been minimized.

Copy link
Member Author

dims commented Mar 7, 2019

/test pull-kubernetes-local-e2e

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 7, 2019

@dims: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e c75fc36 link /test pull-kubernetes-local-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Mar 7, 2019

/skip

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Mar 9, 2019

/milestone v1.14
/kind cleanup

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Mar 9, 2019

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Mar 9, 2019

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Mar 12, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 12, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bb8ccb6 into kubernetes:master Mar 12, 2019

17 checks passed

cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.