Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: reimplement IPVS check #75036

Conversation

@bart0sh
Copy link
Contributor

commented Mar 6, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Used existing IPVS Proxier API CanUseIPVSProxier instead
of custom implementation.

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#975

Special notes for your reviewer:

This is yet another attempt to correctly fix kubernetes/kubeadm#975 and get rid of huge confusing warning message that scares users.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot requested review from detiber and krousey Mar 6, 2019

@bart0sh bart0sh force-pushed the bart0sh:PR0065-kubeadm-replace-RequiredIPVSKernelModulesAvailable-check branch from e1e43e7 to a760d17 Mar 6, 2019

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

/cc @kad @neolit123

@k8s-ci-robot k8s-ci-robot requested review from kad and neolit123 Mar 6, 2019

@bart0sh bart0sh force-pushed the bart0sh:PR0065-kubeadm-replace-RequiredIPVSKernelModulesAvailable-check branch from a760d17 to f3e985e Mar 6, 2019

@neolit123
Copy link
Member

left a comment

@bart0sh
thanks for the cleanup. the change LGTM.
please mind that code freeze is tomorrow..

"verify" needs to pass (there is an import-boss issue).

/approve
/priority important-longterm

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

/test pull-kubernetes-verify

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

/test pull-kubernetes-e2e-gce-100-performance

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

@neolit123 Thank you for the review.

Do you have any idea why import-boss is failing/how to reproduce this?

pull-kubernetes-e2e-gce-100-performance failure seems to be not related to this PR. Some testing infra setup issue I guess.

@neolit123

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

@bart0sh
this ticket has some info what import boss is and how to test locally:
#68201 (comment)

on a quick look it seems not happy with the new dependency from pkg.
you might have to add it here:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/.import-restrictions#L51

@bart0sh bart0sh force-pushed the bart0sh:PR0065-kubeadm-replace-RequiredIPVSKernelModulesAvailable-check branch from f3e985e to 0826e71 Mar 6, 2019

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

/test pull-kubernetes-integration

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

/test pull-kubernetes-verify

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

/test pull-kubernetes-e2e-gce-100-performance

@bart0sh bart0sh force-pushed the bart0sh:PR0065-kubeadm-replace-RequiredIPVSKernelModulesAvailable-check branch from 0826e71 to ea836b5 Mar 7, 2019

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

@neolit123 thank you for the suggestion! That was exactly it - import-boss was not happy about extra dependencies to the bunch of network-related packages.

Show resolved Hide resolved cmd/kubeadm/app/preflight/checks_darwin.go
Show resolved Hide resolved cmd/kubeadm/app/preflight/checks_windows.go
Show resolved Hide resolved cmd/kubeadm/app/preflight/checks.go Outdated
Show resolved Hide resolved cmd/kubeadm/app/preflight/checks.go Outdated

@bart0sh bart0sh force-pushed the bart0sh:PR0065-kubeadm-replace-RequiredIPVSKernelModulesAvailable-check branch from ea836b5 to b04ecbe Mar 12, 2019

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

/test pull-kubernetes-e2e-gce

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

@krousey, @detiber Kindly ping for review/approval.

@detiber
Copy link
Member

left a comment

minor nit, otherwise lgtm

Show resolved Hide resolved cmd/kubeadm/app/preflight/checks_linux.go Outdated
kubeadm: reimplement IPVS check
Used existing IPVS Proxier API CanUseIPVSProxier instead
of custom implementation.

Fixes kubernetes/kubeadm#975

@bart0sh bart0sh force-pushed the bart0sh:PR0065-kubeadm-replace-RequiredIPVSKernelModulesAvailable-check branch from b04ecbe to 2914171 Mar 14, 2019

@detiber

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

/lgtm

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

Assigning to approvers for final approval

/assign @thokin @m1093782566 @timothysc

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

@bart0sh: GitHub didn't allow me to assign the following users: thokin.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Assigning to approvers for final approval

/assign @thokin @m1093782566 @timothysc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

@m1093782566 @timothysc Kindly ping for approval.

@neolit123
Copy link
Member

left a comment

/approve
SGTM on the kubeadm side.

@timothysc
Copy link
Member

left a comment

thanks for the patch, but I have a comment that I'd like an answer to before lgtm
/approve
/hold

@thockin

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, neolit123, thockin, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rosti

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

I think, that this is ready for merge now. Thanks @bart0sh !
/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit f3efd1d into kubernetes:master Mar 25, 2019

14 of 17 checks passed

pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation bart0sh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@bart0sh: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-100-performance 2914171 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-e2e-gce 2914171 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@neolit123

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.