Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initContainer failed to get its own field value as environment variable values #75109

Merged
merged 1 commit into from May 16, 2019

Conversation

@yuchengwu
Copy link
Contributor

commented Mar 7, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix initContainer failed to get its own field value as environment variable values

Which issue(s) this PR fixes:

Fixes #75103

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Allow init container to get its own field value as environment variable values(downwardAPI spport)
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

Hi @yuchengwu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from justinsb and madhusudancs Mar 7, 2019

@yuchengwu yuchengwu force-pushed the yuchengwu:master branch from e374f6f to 0cc36e2 Mar 8, 2019

@yuchengwu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

/assign @smarterclayton

@yuchengwu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

I signed it

1 similar comment
@yuchengwu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

I signed it

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

Not for 1.14.

/ok-to-test

/sig node

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

Is this a regression or just never worked?

@yuchengwu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

I rechecked it just never worked since v1.6.0, as

A cluster with Apiserver version 1.6.0 or greater supports Init Containers using the .spec.initContainers field.

so it is not a regression

@yuchengwu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

I signed it

@yuchengwu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

/sig-node-reviewers

@yuchengwu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

kindly ping
/cc @Random-Liu
/cc @dchen1107
/cc @derekwaynecarr

@yuchengwu yuchengwu force-pushed the yuchengwu:master branch from a65167d to d12df6b May 15, 2019

@yuchengwu

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

rebase on github/master in case there is conflict
/cc @smarterclayton

@k8s-ci-robot k8s-ci-robot requested a review from smarterclayton May 15, 2019

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Sorry for the long delay,

/lgtm
/approve

@yuchengwu

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

The merge is blocked due to I am not an authorized user, do you know how to be ? I checked the link but still don't know how, thanks

@yuchengwu yuchengwu force-pushed the yuchengwu:master branch from d12df6b to 6bcb7d5 May 15, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 15, 2019

@yuchengwu

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

Well, I see, the master branch is protected from unauthorized users.
I misunderstanded that my commit author name is not unauthorized and changed it to my github username then force push.

/retest

please re-approve /cc @smarterclayton , thanks:)

@yuchengwu

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

/retest

@yuchengwu

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, yuchengwu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 16, 2019

@k8s-ci-robot k8s-ci-robot merged commit 8a822b0 into kubernetes:master May 16, 2019

19 of 20 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation yuchengwu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.