Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
kubelet: updated logic of verifying a static critical pod #75144
What type of PR is this?
What this PR does / why we need it:
This is a supplemental fix of #74222.
This PR revers part of #74222 (e2e test is still valid and is kept), and updated the logic of verifying a static critical pod:
Which issue(s) this PR fixes:
Supplemental fix for #73572
Special notes for your reviewer:
Here is a detailed explanation on why previous PR passed the e2e test:
Does this PR introduce a user-facing change?:
2 similar comments
referenced this pull request
Mar 10, 2019
@Huang-Wei - To be clear, my understanding is eventually the mirror pod would be generated again since static pod is not evicted. This will make any static pod to not get evicted which is a side-effect of change introduced in previous PR and now we are ensuring that we are actually evicting non-critical static pods?
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing